Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG] hr_expense_operating_unit #346

Merged
merged 28 commits into from
Jun 3, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
5346044
migrated hr-expense-operating-unit to 9.0
SerpentCS Aug 24, 2016
4b12d3c
added OU to account move
SerpentCS Aug 29, 2016
c1d1539
added Readme file and minor fixes
SerpentCS Aug 29, 2016
eabe1a0
Added Test Cases.
SerpentCS Sep 14, 2016
151923a
Added Copyrights in xml files and made minor changes.
SerpentCS Sep 14, 2016
20c55fc
PEP8 issues
AaronHForgeFlow Sep 15, 2016
147baeb
Add constraint
AaronHForgeFlow Feb 13, 2017
3b07a15
travis
AaronHForgeFlow Feb 14, 2017
5ac3e56
security
LoisRForgeFlow May 9, 2017
55e5e83
[MIG] hr_expense_operating_unit v10
nikul-serpentcs Jul 21, 2017
a7e80c9
[FIX] hr_expense_operating_unit test failing
bjeficent Feb 25, 2019
68e84a4
[MIG] hr_expense_operating_unit: Migration to version 12.0
bjeficent Mar 11, 2019
da43625
[FIX]domain operating units on expenses
AaronHForgeFlow Oct 14, 2019
7ca9f9a
[UPD] Update hr_expense_operating_unit.pot
oca-travis Oct 14, 2019
66f1f58
[UPD] README.rst
OCA-git-bot Oct 14, 2019
653778b
[FIX] Fixed unknown Fields
nikul-serpentcs Dec 30, 2019
eb12e16
hr_expense_operating_unit 12.0.1.0.1
OCA-git-bot Dec 30, 2019
864a6e3
[IMP] hr_expense_operating_unit: black, isort
alan196 Feb 12, 2020
2986aef
[MIG] hr_expense_operating_unit: Migration to V13
alan196 Feb 12, 2020
f8bab9b
[UPD] Update hr_expense_operating_unit.pot
oca-travis Apr 16, 2020
b62c2ab
[UPD] README.rst
OCA-git-bot Apr 16, 2020
79144d7
[FIX] hr_expense_operating_unit: adapt to v13 changes
hbrunn Sep 21, 2020
93048c5
hr_expense_operating_unit 13.0.1.0.1
OCA-git-bot Sep 21, 2020
cdb2b81
[UPD] Eficent -> ForgeFlow
MiquelRForgeFlow Oct 5, 2020
94d2cb2
[UPD] README.rst
OCA-git-bot Oct 5, 2020
74fad0a
[14.0][MIG] hr_expense_operating_unit
kittiu Dec 9, 2020
004dccf
[FIX] multi operating-unit can't create expense sheet
Saran440 Feb 24, 2021
6017910
[FIX] default ou on move
Saran440 Apr 21, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 91 additions & 0 deletions hr_expense_operating_unit/README.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,91 @@
=========================
HR Expense Operating Unit
=========================

.. !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! This file is generated by oca-gen-addon-readme !!
!! changes will be overwritten. !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
:target: https://odoo-community.org/page/development-status
:alt: Beta
.. |badge2| image:: https://img.shields.io/badge/licence-LGPL--3-blue.png
:target: http://www.gnu.org/licenses/lgpl-3.0-standalone.html
:alt: License: LGPL-3
.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Foperating--unit-lightgray.png?logo=github
:target: https://github.com/OCA/operating-unit/tree/13.0/hr_expense_operating_unit
:alt: OCA/operating-unit
.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
:target: https://translation.odoo-community.org/projects/operating-unit-13-0/operating-unit-13-0-hr_expense_operating_unit
:alt: Translate me on Weblate
.. |badge5| image:: https://img.shields.io/badge/runbot-Try%20me-875A7B.png
:target: https://runbot.odoo-community.org/runbot/213/13.0
:alt: Try me on Runbot

|badge1| |badge2| |badge3| |badge4| |badge5|

This module introduces the following features:

* Adds the Operating Unit (OU) to the Expense.

* Security rules are defined to ensure that users can only see the Expense of that Operating Units in which they are allowed access to.

* Adds Operating Unit (OU) to the account moves while generating accounting entries from the expense.

**Table of contents**

.. contents::
:local:

Usage
=====

To use this module create the Operating Unit or use a created one:

#. Once you have an OU, make sure you assign it to the desired User.
#. Create the expense with the OU.
#. The selectable OU are filtered by the users OU's.

Bug Tracker
===========

Bugs are tracked on `GitHub Issues <https://github.com/OCA/operating-unit/issues>`_.
In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us smashing it by providing a detailed and welcomed
`feedback <https://github.com/OCA/operating-unit/issues/new?body=module:%20hr_expense_operating_unit%0Aversion:%2013.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.

Do not contact contributors directly about support or help with technical issues.

Credits
=======

Authors
~~~~~~~

* ForgeFlow S.L.
* Serpent Consulting Services Pvt. Ltd.

Contributors
~~~~~~~~~~~~

* Jordi Ballester Alomar <jordi.ballester@forgeflow.com>
* Serpent Consulting Services Pvt. Ltd. <support@serpentcs.com>
* Jarsa Sistemas <info@jarsa.com.mx>

Maintainers
~~~~~~~~~~~

This module is maintained by the OCA.

.. image:: https://odoo-community.org/logo.png
:alt: Odoo Community Association
:target: https://odoo-community.org

OCA, or the Odoo Community Association, is a nonprofit organization whose
mission is to support the collaborative development of Odoo features and
promote its widespread use.

This module is part of the `OCA/operating-unit <https://github.com/OCA/operating-unit/tree/13.0/hr_expense_operating_unit>`_ project on GitHub.

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.
3 changes: 3 additions & 0 deletions hr_expense_operating_unit/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl.html).
from . import models
from . import tests
17 changes: 17 additions & 0 deletions hr_expense_operating_unit/__manifest__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Copyright 2016-19 ForgeFlow S.L.
# Copyright 2016-19 Serpent Consulting Services Pvt. Ltd.
# License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl.html).

{
"name": "HR Expense Operating Unit",
"version": "14.0.1.0.0",
"license": "LGPL-3",
"author": "ForgeFlow S.L., "
"Serpent Consulting Services Pvt. Ltd.,"
"Odoo Community Association (OCA)",
"website": "https://github.com/OCA/operating-unit",
"category": "Generic Modules/Human Resources",
"depends": ["hr_expense", "account_operating_unit"],
"data": ["views/hr_expense_view.xml", "security/hr_expense_security.xml"],
"installable": True,
}
62 changes: 62 additions & 0 deletions hr_expense_operating_unit/i18n/hr_expense_operating_unit.pot
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
# Translation of Odoo Server.
# This file contains the translation of the following modules:
# * hr_expense_operating_unit
#
msgid ""
msgstr ""
"Project-Id-Version: Odoo Server 13.0\n"
"Report-Msgid-Bugs-To: \n"
"Last-Translator: \n"
"Language-Team: \n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: \n"
"Plural-Forms: \n"

#. module: hr_expense_operating_unit
#: code:addons/hr_expense_operating_unit/models/hr_expense.py:0
#, python-format
msgid ""
"Configuration error. The Company in the Expense and in the Operating Unit "
"must be the same."
msgstr ""

#. module: hr_expense_operating_unit
#: code:addons/hr_expense_operating_unit/models/hr_expense.py:0
#, python-format
msgid ""
"Configuration error. The Operating Unit in the Expense sheet and in the "
"Expense must be the same."
msgstr ""

#. module: hr_expense_operating_unit
#: code:addons/hr_expense_operating_unit/models/hr_expense.py:0
#, python-format
msgid ""
"Configuration error. The company in\n"
" the Expense and in the Operating Unit must be the same"
msgstr ""

#. module: hr_expense_operating_unit
#: model:ir.model,name:hr_expense_operating_unit.model_hr_expense
msgid "Expense"
msgstr ""

#. module: hr_expense_operating_unit
#: model:ir.model,name:hr_expense_operating_unit.model_hr_expense_sheet
msgid "Expense Report"
msgstr ""

#. module: hr_expense_operating_unit
#: model:ir.model.fields,field_description:hr_expense_operating_unit.field_hr_expense__operating_unit_id
#: model:ir.model.fields,field_description:hr_expense_operating_unit.field_hr_expense_sheet__operating_unit_id
msgid "Operating Unit"
msgstr ""

#. module: hr_expense_operating_unit
#: code:addons/hr_expense_operating_unit/models/hr_expense.py:0
#, python-format
msgid ""
"You cannot submit the Expenses having different Operating Units or with no "
"Operating Unit"
msgstr ""
3 changes: 3 additions & 0 deletions hr_expense_operating_unit/models/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl.html).

from . import hr_expense
124 changes: 124 additions & 0 deletions hr_expense_operating_unit/models/hr_expense.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,124 @@
# Copyright 2016-19 ForgeFlow S.L.
# Copyright 2016-19 Serpent Consulting Services Pvt. Ltd.
# License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl.html).).

from odoo import _, api, fields, models
from odoo.exceptions import UserError, ValidationError


class HrExpenseExpense(models.Model):

_inherit = "hr.expense"

operating_unit_id = fields.Many2one(
comodel_name="operating.unit",
string="Operating Unit",
default=lambda self: self.env["res.users"].operating_unit_default_get(),
)

def action_submit_expenses(self):
ctx = self._context.copy()
operating_unit_id = self.mapped("operating_unit_id")
if operating_unit_id and len(operating_unit_id) > 1:
raise UserError(
_(
"Configuration error. The Operating "
"Unit in the Expense sheet and in the "
"Expense must be the same."
)
)
ctx.update({"default_operating_unit_id": operating_unit_id.id})
return super(HrExpenseExpense, self.with_context(ctx)).action_submit_expenses()

@api.constrains("operating_unit_id", "company_id")
def _check_company_operating_unit(self):
for rec in self:
if (
rec.company_id
and rec.operating_unit_id
and rec.company_id != rec.operating_unit_id.company_id
):
raise ValidationError(
_(
"Configuration error. The Company in "
"the Expense and in the Operating "
"Unit must be the same."
)
)

@api.constrains("operating_unit_id", "sheet_id")
def _check_expense_operating_unit(self):
for rec in self:
if (
rec.sheet_id
and rec.sheet_id.operating_unit_id
and rec.operating_unit_id
and rec.sheet_id.operating_unit_id != rec.operating_unit_id
):
raise ValidationError(
_(
"Configuration error. The Operating "
"Unit in the Expense sheet and in the "
"Expense must be the same."
)
)

def _create_sheet_from_expenses(self):
sheet = super()._create_sheet_from_expenses()
if len(self.mapped("operating_unit_id")) != 1 or any(
not expense.operating_unit_id for expense in self
):
raise ValidationError(
_(
"You cannot submit the Expenses having "
"different Operating Units or with "
"no Operating Unit"
)
)
sheet.write({"operating_unit_id": self.mapped("operating_unit_id").id})
return sheet

def _get_account_move_line_values(self):
res = super()._get_account_move_line_values()
for expense in self:
res[expense.id][0].update({"operating_unit_id": self.operating_unit_id.id})
res[expense.id][1].update({"operating_unit_id": self.operating_unit_id.id})
return res

def _prepare_move_values(self):
move_values = super()._prepare_move_values()
move_values["operating_unit_id"] = self.operating_unit_id.id
return move_values


class HrExpenseSheet(models.Model):

_inherit = "hr.expense.sheet"

operating_unit_id = fields.Many2one(
comodel_name="operating.unit",
string="Operating Unit",
default=lambda self: self.env["res.users"].operating_unit_default_get(),
)

@api.onchange("operating_unit_id")
def _onchange_operating_unit_id(self):
if self.operating_unit_id:
self.expense_line_ids.write(
{"operating_unit_id": self.operating_unit_id.id}
)

@api.constrains("operating_unit_id", "company_id")
def _check_company_operating_unit(self):
for rec in self:
if (
rec.company_id
and rec.operating_unit_id
and rec.company_id != rec.operating_unit_id.company_id
):
raise ValidationError(
_(
"""Configuration error. The company in
the Expense and in the Operating Unit must be the same"""
)
)
4 changes: 4 additions & 0 deletions hr_expense_operating_unit/readme/CONTRIBUTORS.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
* Jordi Ballester Alomar <jordi.ballester@forgeflow.com>
* Serpent Consulting Services Pvt. Ltd. <support@serpentcs.com>
* Jarsa Sistemas <info@jarsa.com.mx>
* Saran Lim. <saranl@ecosoft.co.th>
7 changes: 7 additions & 0 deletions hr_expense_operating_unit/readme/DESCRIPTION.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
This module introduces the following features:

* Adds the Operating Unit (OU) to the Expense.

* Security rules are defined to ensure that users can only see the Expense of that Operating Units in which they are allowed access to.

* Adds Operating Unit (OU) to the account moves while generating accounting entries from the expense.
5 changes: 5 additions & 0 deletions hr_expense_operating_unit/readme/USAGE.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
To use this module create the Operating Unit or use a created one:

#. Once you have an OU, make sure you assign it to the desired User.
#. Create the expense with the OU.
#. The selectable OU are filtered by the users OU's.
30 changes: 30 additions & 0 deletions hr_expense_operating_unit/security/hr_expense_security.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
<?xml version="1.0" encoding="utf-8" ?>
<!-- Copyright 2016-19 ForgeFlow S.L.
Serpent Consulting Services Pvt. Ltd.
License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl-3.0) -->
<odoo>
<record id="ir_rule_hr_expense_allowed_operating_units" model="ir.rule">
<field name="model_id" ref="hr_expense.model_hr_expense" />
<field
name="domain_force"
>['|',('operating_unit_id','=',False),('operating_unit_id','in',[g.id for g in user.operating_unit_ids])]</field>
<field name="name">Expenses from allowed operating units</field>
<field name="global" eval="True" />
<field eval="0" name="perm_unlink" />
<field eval="0" name="perm_write" />
<field eval="1" name="perm_read" />
<field eval="0" name="perm_create" />
</record>
<record id="ir_rule_hr_expense_sheet_allowed_operating_units" model="ir.rule">
<field name="model_id" ref="hr_expense.model_hr_expense_sheet" />
<field
name="domain_force"
>['|',('operating_unit_id','=',False),('operating_unit_id','in',[g.id for g in user.operating_unit_ids])]</field>
<field name="name">Expenses from allowed operating units</field>
<field name="global" eval="True" />
<field eval="0" name="perm_unlink" />
<field eval="0" name="perm_write" />
<field eval="1" name="perm_read" />
<field eval="0" name="perm_create" />
</record>
</odoo>
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading