Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG] sale_operating_unit #365

Closed
wants to merge 5 commits into from
Closed

[14.0][MIG] sale_operating_unit #365

wants to merge 5 commits into from

Conversation

cramosh
Copy link

@cramosh cramosh commented Apr 8, 2021

Migrate module to version 14.0.
replacement onchange by stored calculated fields

@RujiaL
Copy link

RujiaL commented Jun 15, 2021

This pull request needs to meet the instructions in Migrate to version 14.0

@Freni-OSI
Copy link

Hi @cramosh, Can you add commits history? then it will be ready to merge. Thanks.

@patrickrwilson
Copy link
Contributor

Hi @cramosh, Do you plan to work this by adding the commits history or is it ok for someone else to finish this so it can be reviewed?

@Chanakya-OSI
Copy link

Hi, @cramosh Do you plan to work on it?

@alielnagar
Copy link

hello all
when this module will be ready for use ?
please migrate it

@cramosh
Copy link
Author

cramosh commented Apr 7, 2022

Hi @cramosh, Can you add commits history? then it will be ready to merge. Thanks.

What do you mean by adding commit history?

@francesco-ooops
Copy link

Hi @cramosh, Can you add commits history? then it will be ready to merge. Thanks.

What do you mean by adding commit history?

@cramosh It means that you need to include in the PR all the commits present in this module before migration, while in this PR only commits authored by you are present

see for example migrations #332, #343 or #328

On a side note: I was looking at the migration guide and I didn't find a specific part on keeping commit history (which is a fairly common error in migrations), @pedrobaeza could you provide any direction regarding this? thanks!

@pedrobaeza
Copy link
Member

The technical method includes such steps (the git format-patch part) for preserving the commit history.

@francesco-ooops
Copy link

The technical method includes such steps (the git format-patch part) for preserving the commit history.

thanks for clarifying!

@cramosh
Copy link
Author

cramosh commented Apr 11, 2022

How can I check if the history is already added.

It would be better to remove this PR and redo the migration from 0 following the OCA guide

@ilyasProgrammer
Copy link
Member

How can I check if the history is already added.

It would be better to remove this PR and redo the migration from 0 following the OCA guide

@cramosh yes it would be easier. Could you do that please?

@max3903 max3903 changed the title [14.0][MIG] migration of module sale_operating_unit [14.0][MIG] sale_operating_unit Oct 25, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants