-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][MIG] sale_operating_unit #365
Conversation
This pull request needs to meet the instructions in Migrate to version 14.0 |
Hi @cramosh, Can you add commits history? then it will be ready to merge. Thanks. |
Hi @cramosh, Do you plan to work this by adding the commits history or is it ok for someone else to finish this so it can be reviewed? |
Hi, @cramosh Do you plan to work on it? |
hello all |
What do you mean by adding commit history? |
@cramosh It means that you need to include in the PR all the commits present in this module before migration, while in this PR only commits authored by you are present see for example migrations #332, #343 or #328 On a side note: I was looking at the migration guide and I didn't find a specific part on keeping commit history (which is a fairly common error in migrations), @pedrobaeza could you provide any direction regarding this? thanks! |
The technical method includes such steps (the |
thanks for clarifying! |
How can I check if the history is already added. It would be better to remove this PR and redo the migration from 0 following the OCA guide |
@cramosh yes it would be easier. Could you do that please? |
Migrate module to version 14.0.
replacement onchange by stored calculated fields