Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] stock_operating_unit: Migration to 17.0 #673

Merged
merged 67 commits into from
Aug 5, 2024
Merged

[MIG] stock_operating_unit: Migration to 17.0 #673

merged 67 commits into from
Aug 5, 2024

Conversation

jdidderen-nsi
Copy link
Contributor

@jdidderen-nsi jdidderen-nsi commented May 29, 2024 •
edited by gurneyalex
Loading

@AaronHForgeFlow
Copy link
Contributor

/ocabot migration stock_operating_unit

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone May 29, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request May 29, 2024
Open
16 tasks
@jdidderen-nsi jdidderen-nsi force-pushed the 17.0-mig-stock_operating_unit branch from ac27757 to d50283c Compare May 29, 2024 13:33
@jdidderen-nsi
Copy link
Contributor Author

Open discussion for the constraint on locations : _check_required_operating_unit

In previous versions of the module, the operating unit was mandatory on locations (except customer and supplier ones). In the case of one of my projects, the customer wants to have a "central" warehouse common to all operating units. With the constraint, I have to define an operating unit, even if it's not coherent with the business need. 

Right now, I remove this part of the code from the constraint, but maybe there is another solution. 

What's the opinion on this?

@AaronHForgeFlow
Copy link
Contributor

I am not completely sure, but I think the condition is there mainly for correctly inventory accounting, so to ensure that the inventory value is owned by a specific operating unit. If that is the case maybe we can move the contraint to the stock_account_operating_unit module.

Another solution is to consider using hierarchy in operating units: #319 like if the parent OU represents the company. This approach is more complex because all the contraints definitions should be refactored.

This was referenced Jun 11, 2024
Open
Merged
nguyenminhchien
nguyenminhchien suggested changes Jun 13, 2024
View reviewed changes
Copy link

@nguyenminhchien nguyenminhchien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take this occasion to squash administrative commits (if any) with the previous commit for reducing commit noise.
Squash your 2 commits with [MIG] stock_operating_unit: Migration to 17.0
image

Thanks,

stock_operating_unit/view/stock.xml Outdated
groups="operating_unit.group_multi_operating_unit"
readonly="state == 'draft'"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readonly when "state != 'draft'"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 👍

@nguyenminhchien nguyenminhchien mentioned this pull request Jun 14, 2024
Merged
1 task
@jdidderen-nsi jdidderen-nsi force-pushed the 17.0-mig-stock_operating_unit branch from 168c949 to f28909c Compare June 24, 2024 13:37
JordiBForgeFlow and others added 18 commits July 8, 2024 21:53
@JordiBForgeFlow @jdidderen-nsi
stock_operating_unit
4e97132
@JordiBForgeFlow @jdidderen-nsi
flake8 issues
f571c5a
@JordiBForgeFlow @jdidderen-nsi
flake 8
dc96023
@JordiBForgeFlow @jdidderen-nsi
flake 8
837a489
@AaronHForgeFlow @jdidderen-nsi
update contributors
f46dda4
@AaronHForgeFlow @jdidderen-nsi
code style
93082c0
@AaronHForgeFlow @jdidderen-nsi
constraint that checks the OU in the picking matches the one in the move
089c25c
@JordiBForgeFlow @jdidderen-nsi
the operating unit in pickings should derive from the picking type
1cd218c
@AaronHForgeFlow @jdidderen-nsi
travis issues
01a7bab
@AaronHForgeFlow @jdidderen-nsi
travis issues and test stock picking
8ddf135
@AaronHForgeFlow @jdidderen-nsi
test stock security according picking 1 in test_stock_picking
820f121
@AaronHForgeFlow @jdidderen-nsi
Update operating units of previous locations
c5d89a9
@AaronHForgeFlow @jdidderen-nsi
lint check operating_unit_id readonly in the picking
4cc80fe
@guewen @jdidderen-nsi
Correct error message and xml files
2ab6f65 
* Replace <openerp> and <data> elements by <odoo>
* Remove spaces in strings introduced because of \
* Remove exclamation points in error messages
* Remove most of the \ where it can be replaced by parenthesis
@AaronHForgeFlow @jdidderen-nsi
[MIG] stock_operating_unit to v10.0
1a31c24
@esthermm @jdidderen-nsi
[FIX] stock_operating_unit: correct constrain function, avoid error o…
564dcb5 
…n pickings
@AaronHForgeFlow @jdidderen-nsi
[FIX]onchange does not work with readonly fields
1891532
@AaronHForgeFlow @jdidderen-nsi
[FIX]stock.move._check_stock_move_operating_unit
9473249
Saran440 and others added 20 commits July 8, 2024 21:53
@Saran440 @jdidderen-nsi
[FIX] stock_operating_unit: filter domain users out
35e895f
@OCA-git-bot @jdidderen-nsi
stock_operating_unit 15.0.1.1.0
3d25199
@ps-tubtim @jdidderen-nsi
[FIX] stock_operating_unit: remove domain of operation type
7c5e4e8
@OCA-git-bot @jdidderen-nsi
stock_operating_unit 15.0.1.2.0
80b8184
@AaronHForgeFlow @jdidderen-nsi
[FIX] stock_operating_unit: migration script to 15.0
60b21fb
@Borruso @jdidderen-nsi
[MIG] stock_operating_unit: Migration to 16.0
c6b426b
@jdidderen-nsi
[UPD] Update stock_operating_unit.pot
ec60c15
@OCA-git-bot @jdidderen-nsi
[UPD] README.rst
844fc29
@OCA-git-bot @jdidderen-nsi
[UPD] README.rst
b38bde8
@weblate @jdidderen-nsi
Update translation files
e8910d4 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: operating-unit-16.0/operating-unit-16.0-stock_operating_unit
Translate-URL: https://translation.odoo-community.org/projects/operating-unit-16-0/operating-unit-16-0-stock_operating_unit/
@AaronHForgeFlow @jdidderen-nsi
[FIX] stock_operating_unit: access to picking types when warehouse is…
e85d5da 
… not set
@Borruso @jdidderen-nsi
[FIX] stock_operating_unit: fix view field not in form
20dfcfa
@OCA-git-bot @jdidderen-nsi
oca-github-bot post-merge updates
e3debca
@OCA-git-bot @jdidderen-nsi
[BOT] post-merge updates
2c9d8b4
@AaronHForgeFlow @jdidderen-nsi
[IMP] stock_operating_unit: proper error message in location misconfi…
6db729f 
…guration
@jdidderen-nsi
[UPD] Update stock_operating_unit.pot
ee57f3c
@OCA-git-bot @jdidderen-nsi
[BOT] post-merge updates
94bd842
@weblate @jdidderen-nsi
Update translation files
26889be
@jdidderen-nsi
[IMP] stock_operating_unit: pre-commit execution
ffc57ec
@jdidderen-nsi
[MIG] stock_operating_unit: Migration to 17.0
d8322a7
@jdidderen-nsi jdidderen-nsi force-pushed the 17.0-mig-stock_operating_unit branch from f28909c to d8322a7 Compare July 8, 2024 19:53
yvaucher
yvaucher approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@yvaucher yvaucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yvaucher
Copy link
Member

yvaucher commented Aug 5, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-673-by-yvaucher-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 466d4e1 into OCA:17.0 Aug 5, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a2d0fda. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyenminhchien nguyenminhchien nguyenminhchien approved these changes

@yvaucher yvaucher yvaucher approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.