-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] sale_stock_operating_unit: Migration to 17.0 #676
[MIG] sale_stock_operating_unit: Migration to 17.0 #676
Conversation
/ocabot migration sale_stock_operating_unit |
da4c0a7
to
32858c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good overall, just left 2 comments for considering.
@@ -12,7 +12,7 @@ def _get_new_picking_values(self): | |||
""" | |||
Override to add Operating Units to Picking. | |||
""" | |||
values = super(StockMove, self)._get_new_picking_values() | |||
values = super()._get_new_picking_values() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in my opinion, it's not necessary to override this function. we have a constraint to make sure the order and its warehouse having the same value of operating_unit_id
. So, just let the field stock_picking.operating_unit_id
computes the value itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The operating unit is not mandatory on the warehouse and then you could have a shared warehouse and having pickings from several operating units. In that case, the compute will not work.
("warehouse_id", "=", rec.id), | ||
("operating_unit_id", "!=", rec.operating_unit_id.id), | ||
] | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should add limit=1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 👍
32858c8
to
fe9a73d
Compare
fe9a73d
to
307da6e
Compare
All dependencies have been merge, please refresh the PR by removing the test-requirement change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
od the company [FIX]access operating unit of the sales team
Currently translated at 100.0% (5 of 5 strings) Translation: operating-unit-12.0/operating-unit-12.0-sale_stock_operating_unit Translate-URL: https://translation.odoo-community.org/projects/operating-unit-12-0/operating-unit-12-0-sale_stock_operating_unit/pt/
Currently translated at 100.0% (5 of 5 strings) Translation: operating-unit-12.0/operating-unit-12.0-sale_stock_operating_unit Translate-URL: https://translation.odoo-community.org/projects/operating-unit-12-0/operating-unit-12-0-sale_stock_operating_unit/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: operating-unit-15.0/operating-unit-15.0-sale_stock_operating_unit Translate-URL: https://translation.odoo-community.org/projects/operating-unit-15-0/operating-unit-15-0-sale_stock_operating_unit/
Currently translated at 80.0% (4 of 5 strings) Translation: operating-unit-15.0/operating-unit-15.0-sale_stock_operating_unit Translate-URL: https://translation.odoo-community.org/projects/operating-unit-15-0/operating-unit-15-0-sale_stock_operating_unit/it/
Currently translated at 100.0% (5 of 5 strings) Translation: operating-unit-15.0/operating-unit-15.0-sale_stock_operating_unit Translate-URL: https://translation.odoo-community.org/projects/operating-unit-15-0/operating-unit-15-0-sale_stock_operating_unit/it/
307da6e
to
a968b41
Compare
This PR has the |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 018904c. Thanks a lot for contributing to OCA. ❤️ |
Depends on: