-
-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][FIX] purchase_manual_delivery: manual delivery with double validation #2189
base: 16.0
Are you sure you want to change the base?
Conversation
5639dbe
to
377b159
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@astirpe Due to a conflict with a merge just now of another PR, your new test in this PR needs to be moved down a little bit. |
Picked in my 17.0 migration #2417 |
377b159
to
2e4da40
Compare
Unfortunately an access error now appears in your test
|
@StefanRijnhart Yes, I noticed. I will fix it as soon as I have some time. Thank you! |
@StefanRijnhart It seems to me that the access error of the test is caused by the definition of Not sure how to fix it. |
When "Purchase Order Approval" is enabled and the PO exceeds the Minimum Amount, the manual delivery is not applied at the moment that the PO is approved.
This PR fixes this case.