Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][UPD] purchase_manual_delivery: do not show incoming shipment button #2401

Merged
merged 1 commit into from
Sep 26, 2024
Merged

[16.0][UPD] purchase_manual_delivery: do not show incoming shipment button #2401

merged 1 commit into from
Sep 26, 2024

Conversation

ntsirintanis
Copy link
Contributor

purchase_manual_delivery: Hide 'create incoming shipment' button when the purchase order is not configured for manual delivery.

@gfcapalbo
Copy link

Makes sense to hide the "create shipment" button on manual delivery too. LGTM 👍

flotho
flotho approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree,
make sense
LGTM

StefanRijnhart
StefanRijnhart reviewed Sep 26, 2024
View reviewed changes
purchase_manual_delivery/__manifest__.py
@@ -8,7 +8,7 @@
and adds the ability to manually generate them as the supplier confirms
the different purchase order lines.
""",
"version": "16.0.1.1.4",
"version": "16.0.1.1.5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next time, you don't have to update the version number yourself. Ocabot will do the honours.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@StefanRijnhart
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-2401-by-StefanRijnhart-bump-nobump, awaiting test results.

@StefanRijnhart
Copy link
Member

@ntsirintanis Can I interest you to review other open PRs for this module? #2383, #2189

@OCA-git-bot OCA-git-bot merged commit c17406f into OCA:16.0 Sep 26, 2024
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1ea5919. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

@flotho flotho flotho approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ntsirintanis @gfcapalbo @OCA-git-bot @StefanRijnhart @flotho