-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] sale_global_discount: standard migration to 17.0 #3025
Open
miguel-S73
wants to merge
44
commits into
OCA:17.0
Choose a base branch
from
Studio73:17.0-mig-sale_global_discount
base: 17.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguel-S73
force-pushed
the
17.0-mig-sale_global_discount
branch
from
March 18, 2024 10:29
d792d64
to
267873a
Compare
/ocabot migration sale_global_discount |
miguel-S73
changed the title
[MIG] sale_global_discount: 17.0
[17.0][MIG] sale_global_discount: standard migration to 17.0
Aug 14, 2024
miguel-S73
force-pushed
the
17.0-mig-sale_global_discount
branch
from
August 14, 2024 16:32
267873a
to
6c0ddbf
Compare
ferran-S73
force-pushed
the
17.0-mig-sale_global_discount
branch
from
September 27, 2024 06:49
6c0ddbf
to
fd1778d
Compare
miguel-S73
force-pushed
the
17.0-mig-sale_global_discount
branch
from
November 6, 2024 15:02
fd1778d
to
9411829
Compare
Currently translated at 100.0% (6 of 6 strings) Translation: sale-workflow-11.0/sale-workflow-11.0-sale_global_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-11-0/sale-workflow-11-0-sale_global_discount/es/
Not all taxes combinations are possible with global discounts when they are later invoiced and posted, so we need to constraint them early. OCA/account-invoicing#745 addresses the problem at invoice level, posting correctly taxes for supported cases, and constraining the rest. We apply here the same constraints at sales order level. Existing tests have been changed because they were using one of the forbidden taxes combination, and 2 new tests have been added for covering the new constraints.
* Standard procedure * Code adaptation * README regeneration * Tests adaptation [UPD] Update sale_global_discount.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_global_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_global_discount/ Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_global_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_global_discount/
Currently translated at 100.0% (9 of 9 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_global_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_global_discount/pt/
Currently translated at 100.0% (9 of 9 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_global_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_global_discount/pt/
The tuple has changed from 4 to 6 elements. [UPD] Update sale_global_discount.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_global_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_global_discount/
Only global discount managers can set global discounts [UPD] Update sale_global_discount.pot
Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_global_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_global_discount/
[UPD] Update sale_global_discount.pot
Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_global_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_global_discount/ [UPD] Update sale_global_discount.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_global_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_global_discount/
Currently translated at 100.0% (10 of 10 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_global_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_global_discount/pt/
Currently translated at 100.0% (10 of 10 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_global_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_global_discount/es/
[UPD] Update sale_global_discount.pot [UPD] README.rst
This one is not present anymore in this version.
…sts to prevent errors if company have default currency distinct to default priceslist
…e other standard computed fields in same method are
Currently translated at 100.0% (13 of 13 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_global_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_global_discount/it/
…of base_global_discount In this way we also include the following configuration step: * Go to *Settings > Users*, choose yours and set *Manage Global Discounts* Without this *Global Discounts* doesn't show up!
…ues on big database installation
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_global_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_global_discount/
Currently translated at 100.0% (12 of 12 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_global_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_global_discount/it/
miguel-S73
force-pushed
the
17.0-mig-sale_global_discount
branch
2 times, most recently
from
November 19, 2024 12:41
58c9fb4
to
3cb66d0
Compare
ferran-S73
force-pushed
the
17.0-mig-sale_global_discount
branch
from
December 17, 2024 17:29
3cb66d0
to
724326a
Compare
ferran-S73
force-pushed
the
17.0-mig-sale_global_discount
branch
from
December 17, 2024 17:32
724326a
to
0380a22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard migration to 17.0
Depends: