[17.0][MIG] sale_blanket_order #3255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When duplicating a confirmed blanket order, the new copy shouldn't keep the state nor the sequence number (name).
Steps to reproduce: * create and confirm a blanket order (BO) with (product A, qty 30) and (product B, qty 20) * from the BO create a SO with (product A, qty 10) and (product B, qty 10) * from the BO create a SO with (product A, qty 20) and (product B, qty 0) * from the BO create another SO with (product B, qty 10) Current behavior: It raises the exception "The sale has already been completed.". Expected behavior: No exception is raised.
Currently translated at 7.1% (11 of 154 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_blanket_order Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_blanket_order/de/
exactly like in sales orders.
* Allow to select an analitic account in the blanket order. It will be passed on to the SO. * Allow to select analytic tags on blanket order lines. They will be passed to the SO lines. * Source document was not being filled in SO created from a blanket order.
…dy set Otherwise use case same as that one written in https://github.com/OCA/sale-workflow/blob/14.0/sale_shipping_info_helper/tests/test_sale_shipping_info_helper.py#L22 fails See https://app.travis-ci.com/github/OCA/sale-workflow/jobs/555432793#L3103-L3107 as reference
Currently translated at 100.0% (172 of 172 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_blanket_order Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_blanket_order/es/
Currently translated at 100.0% (170 of 170 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_blanket_order Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_blanket_order/it/
This was referenced Jul 29, 2024
|
@OCA/core-maintainers can someone review this PR? |
|
@sanderlienaerts can you review? |
dreispt
reviewed
Jul 30, 2024
dreispt
approved these changes
Jul 30, 2024
sanderlienaerts
suggested changes
Jul 31, 2024
chrisb-c01
force-pushed
the
17.0-mig-sale_blanket_order
branch
from
cb61297 to
e48f1b6
Compare
|
@sanderlienaerts can you please retest? |
|
Hi @SMaciasOSI, tagging you here since the bot was unable to |
2 tasks
|
/ocabot migration sale_blanket_order |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 57ad6f4. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on / supersedes #3014