[17.0] [ADD] sale_blanket_order_tier_validation #3277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nikul-OSI
force-pushed
the
17_add_sale_blanket_order_tier_validation
branch
from
4903a4b to
a61d983
Compare
| def action_confirm(self): | ||
| """Set the state to 'Open' when clicking confirmed instead of during compute.""" | ||
| for rec in self: | ||
| rec.write({"state": "open"}) |
There was a problem hiding this comment.
FYI I did OCA/server-ux#939 so that tier validations can be applied to computed state fields as in this model.
There was a problem hiding this comment.
Would you consider reviewing that change and refactoring this module to work with it? You wouldn't have to jump through hoops like you do in the code above.
There was a problem hiding this comment.
I did the refactoring in ursais#14. What do you think?
|
@Nikul-OSI Could you rebase ? |
Nikul-OSI
force-pushed
the
17_add_sale_blanket_order_tier_validation
branch
from
a61d983 to
1ff1f88
Compare
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on
sale_blanket_order [17.0][MIG] sale_blanket_order #3255
base_tier_validation https://github.com/OCA/server-ux/tree/17.0/base_tier_validation