[FIX] sale_substate: fix inheritance order #3483
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the current order, the super to _track_template from the mixin was never called. Which was a good thing since it was also buggy; however the override in this model was removed on the assumption that it was.
|
Hello @rousseldenis |
There was a problem hiding this comment.
You can fix the tests by adding your version of base_substate in test-requirements.txt
Something like
git+https://github.com/lambdao-dev/server-ux@17.0-fxsbsttmx-len#subdirectory=base_substate
Would it be possible to add a test to validate that tracking has taken place, so that it is signalled when this goes wrong again after some future Odoo internal refactoring or so.
|
Working test added, it should be the same for other repair_substate or purchase_substate modules. |
StefanRijnhart
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current order, the super to _track_template from the mixin was never called. Which was a good thing since it was also buggy;
however the override in this model was removed on the assumption that it was.
Depends on OCA/server-ux#982 since the super function is actually borked.
(it's therefore expected tests crash before the dependencies are updated)
Also, the problem is present in other substate modules like
purchase_substatebut their migration is in limbo so it's all good.