[FIX] base_substate: migrate track_template function #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that because inheritance was poorly implemented in inheriting modules (such as sale_substate) this function was never called, hiding the bug. auto_delete_message was removed in odoo@9140ce06
StefanRijnhart
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Thanks! We can see inhttps://github.com/OCA/sale-workflow/pull/3483 that it's working.
|
Thanks, Can you add tests like in V15 version in #735 |
|
@bosd no, I don't think this test really makes sense as the test class is really too poor of a mock to be a good test. I would rather make a test_base_substate module, but sale_substate already exist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that because inheritance was poorly implemented in inheriting modules (such as sale_substate) this function was never called, hiding the bug.
auto_delete_message was removed in odoo@9140ce06
Note that the issue was reported before the migration:
#855 (comment)