-
-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] account_move_line_stock_info #2221
base: 18.0
Are you sure you want to change the base?
[18.0][MIG] account_move_line_stock_info #2221
Conversation
* [ADD] account_move_line_stock_info
Currently translated at 100.0% (4 of 4 strings) Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-account_move_line_stock_info Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-account_move_line_stock_info/pt_BR/
Currently translated at 100.0% (4 of 4 strings) Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-account_move_line_stock_info Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-account_move_line_stock_info/de/
Currently translated at 100.0% (4 of 4 strings) Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-account_move_line_stock_info Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-account_move_line_stock_info/zh_CN/
Currently translated at 100.0% (4 of 4 strings) Translation: stock-logistics-warehouse-15.0/stock-logistics-warehouse-15.0-account_move_line_stock_info Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-15-0/stock-logistics-warehouse-15-0-account_move_line_stock_info/ca/
Currently translated at 100.0% (4 of 4 strings) Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-account_move_line_stock_info Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-account_move_line_stock_info/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-account_move_line_stock_info Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-account_move_line_stock_info/
Currently translated at 100.0% (4 of 4 strings) Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-account_move_line_stock_info Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-account_move_line_stock_info/es/
Currently translated at 50.0% (2 of 4 strings) Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-account_move_line_stock_info Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-account_move_line_stock_info/it/
Currently translated at 100.0% (4 of 4 strings) Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-account_move_line_stock_info Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-account_move_line_stock_info/it/
Currently translated at 100.0% (4 of 4 strings) Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-account_move_line_stock_info Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-account_move_line_stock_info/fr/
* Minor adjustments * Attrs substitution * Readme update * Add the journal items to the simlified operations form view Co-authored-by: stefan@opener.amsterdam
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-17.0/stock-logistics-warehouse-17.0-account_move_line_stock_info Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-17-0/stock-logistics-warehouse-17-0-account_move_line_stock_info/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code review 👍🏼
@@ -80,7 +80,6 @@ def _create_account(self, acc_type, name, code, company): | |||
"name": name, | |||
"code": code, | |||
"account_type": acc_type, | |||
"company_id": company.id, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use company_ids
now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, Thanks
_inherit = "account.move.line" | ||
|
||
stock_move_id = fields.Many2one( | ||
comodel_name="stock.move", string="Stock Move", copy=False, index=True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pplease use the same index as in https://github.com/odoo/odoo/tree/18.0/addons/stock_account/models#L10
Is this redefinition even needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
index updated,
and field is availble on account.move not on account.move.line
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. Sorry.
ed7214e
to
27fc5df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Standard Migration
@ForgeFlow