Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AD20-16: Support to cancel docker execution #371

Merged
merged 1 commit into from
Jan 24, 2024
Merged

AD20-16: Support to cancel docker execution #371

merged 1 commit into from
Jan 24, 2024

Conversation

hernaldourbina
Copy link
Contributor

@hernaldourbina hernaldourbina commented Jan 10, 2024 •
edited by dmitrys-odysseus
Loading

Cancel/stop feature. There was an endpoint for handling cancel feature, cancel already works for tarball mode but it is not implemented yet for docker.

@dmitrys-odysseus dmitrys-odysseus changed the title AD20-16: Cancel feature and logging issue AD20-16: Support to cancel docker execution Jan 11, 2024
dmitrys-odysseus
dmitrys-odysseus requested changes Jan 17, 2024
View reviewed changes
engine/src/main/java/com/odysseusinc/arachne/executionengine/execution/r/DockerOverseer.java Outdated Show resolved Hide resolved
engine/src/main/java/com/odysseusinc/arachne/executionengine/execution/r/DockerOverseer.java Outdated Show resolved Hide resolved
engine/src/main/java/com/odysseusinc/arachne/executionengine/execution/r/DockerOverseer.java Outdated Show resolved Hide resolved
engine/src/main/java/com/odysseusinc/arachne/executionengine/execution/r/DockerOverseer.java Outdated Show resolved Hide resolved
engine/src/main/java/com/odysseusinc/arachne/executionengine/execution/r/DockerOverseer.java Outdated Show resolved Hide resolved
engine/src/main/java/com/odysseusinc/arachne/executionengine/execution/r/DockerOverseer.java Outdated Show resolved Hide resolved
@dmitrys-odysseus
Copy link
Contributor

Defect: Still doesn't work for the case when container is being pulled.
The expected behaviour is not to start the container.
What currently happens is that container starts and then stopping it is attempted.

dmitrys-odysseus
dmitrys-odysseus requested changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@dmitrys-odysseus dmitrys-odysseus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

State reporting is still incorrect

engine/src/main/java/com/odysseusinc/arachne/executionengine/execution/r/DockerOverseer.java Outdated Show resolved Hide resolved
engine/src/main/java/com/odysseusinc/arachne/executionengine/execution/r/DockerOverseer.java Outdated Show resolved Hide resolved
engine/src/main/java/com/odysseusinc/arachne/executionengine/execution/r/DockerOverseer.java Outdated Show resolved Hide resolved
@dmitrys-odysseus dmitrys-odysseus merged commit 0c31f67 into OHDSI:develop Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitrys-odysseus dmitrys-odysseus dmitrys-odysseus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hernaldourbina @dmitrys-odysseus