DA_France refresh #657
DA_France refresh #657
Conversation
…ar and replicable definition for concept_naming, *DDL and source format mismatch [may be fixed based on findings from Documentation shared/(archived) LS analysis]). Current approach (actual LS) is powered for small refreshes only neither than to provide efficient vocabulary maintenance. Comments to define appropriate relationships for source fields and target table entities. Updates statements are added in create_source_tables.sql.
…o da_france_july_2022
There was a problem hiding this comment.
- Never ever recreate the files. Just move them in order to preserve the history. Once the old file is moved, you can create a new file with the same name in a separate commit.
- Updates are not allowed in the source tables. Any manipulations are to be done in the ls or manual work.
- Manual work is missing. How did we populate the manual tables?
|
@vladkorsik @TinyRickC137 I will run it now in devv5 schema because we get good results from the latest run. But let's fix it as requested within a new branch. |
|
@Alexdavv Agree with 1 and 2, but regarding 3: |
|
We normally place it at the respective “manual_work” folder. What was wrong with the LPD_Australia so that I asked you to drop a manual part? |
|
It was altogether with manual checks in our private repositories and you said, that checks and insertions are for the person who does the vocab only, no need to make it available in the community nor to put it in our private repo. |
|
Checks are different because we don’t want to replicate the standard code. For the rest - it comes to git. |
|
What's the priority for this task? Can you please provide good instruction on what to do with manual vocabularies? There are other LPDs coming sooner or later. The team would appreciate clear instructions to avoid misunderstanding. |
|
@TinyRickC137 As I said, it was already run in devv5. So it will be merged once you fixed what was requested. |
Restored source_tables -- Manual work is populated
|
@Alexdavv please take a look at the Commit with rolback of Source. |
|
More work has been done in branch 'da_france', |
The entire DA_France machinery is moved to Archive (rational: *no clear and replicable definition for concept_naming, *DDL and source format mismatch [may be fixed based on findings from Documentation shared/(archived) LS analysis]).
The current approach (actual LS) is powered for only minor refreshes to provide efficient vocabulary maintenance.
Comments to define appropriate relationships for source fields and target table entities.
Updates statements are added in create_source_tables.sql.