Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(segmentation): Use the series description for the segmentation label #3517

Merged

Conversation

jbocce
Copy link
Contributor

@jbocce jbocce commented Jul 4, 2023

Context

Fixes issue #3426

Changes & Results

Use the series description for the segmentation label.
Do not allow the segmentation label to wrap in the SegmentationGroup header. Instead use an ellipsis.

Testing

Test the associated issue.

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: Windows 11
  • Node version: 16.14.0
  • Browser: Chrome 114.0.5735.199

…bel.

Do not allow the segmentation label to wrap in the SegmentationGroup header.
Instead use an ellipsis.
@jbocce jbocce requested a review from sedghi July 4, 2023 16:57
@netlify
Copy link

netlify bot commented Jul 4, 2023

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit bd8eff7
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/64a44f5b3c286c00082faf8a
😎 Deploy Preview https://deploy-preview-3517--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 4, 2023

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit bd8eff7
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/64a44f5b8d2bcd00081de41f
😎 Deploy Preview https://deploy-preview-3517--ohif-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #3517 (bd8eff7) into master (b5599dd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3517   +/-   ##
=======================================
  Coverage   42.81%   42.81%           
=======================================
  Files          82       82           
  Lines        1448     1448           
  Branches      338      338           
=======================================
  Hits          620      620           
  Misses        665      665           
  Partials      163      163           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0a456a...bd8eff7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants