Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release candidate 3p7 RC1 #3680

Closed
wants to merge 292 commits into from
Closed

release candidate 3p7 RC1 #3680

wants to merge 292 commits into from

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Sep 26, 2023

Context

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

ohif-bot and others added 30 commits June 19, 2023 13:08
Co-authored-by: Igor Octaviano <igor.octaviano@radicalimaging.com>
Add checks to include volume3d viewports.
@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for ohif-prod ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/ohif-prod/deploys/651351418473361d938e4a9d
😎 Deploy Preview https://deploy-preview-3680--ohif-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release@72ec0bf). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             release    #3680   +/-   ##
==========================================
  Coverage           ?   46.23%           
==========================================
  Files              ?       78           
  Lines              ?     1276           
  Branches           ?      312           
==========================================
  Hits               ?      590           
  Misses             ?      548           
  Partials           ?      138           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72ec0bf...38d46a7. Read the comment docs.

@cypress
Copy link

cypress bot commented Sep 26, 2023

2 failed tests on run #3583 ↗︎

2 34 0 1 Flakiness 0

Details:

Merge branch 'release' of github.com:OHIF/Viewers into release-candidate-3p7
Project: Viewers Commit: 38d46a7de6
Status: Failed Duration: 05:06 💡
Started: Sep 26, 2023 9:49 PM Ended: Sep 26, 2023 9:54 PM
Failed  OHIFCornerstoneToolbar.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF Cornerstone Toolbar > checks if Length annotation can be added to viewport and shows up in the measurements panel Test Replay Output Screenshots Video
Failed  OHIFStudyBrowser.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF Study Viewer Page > drags and drop a series thumbnail into viewport Test Replay Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@daker
Copy link

daker commented Oct 10, 2023

@sedghi hi, do you have an ETA for the release?

@sedghi
Copy link
Member Author

sedghi commented Oct 10, 2023

@daker this week

@sedghi sedghi changed the title release candidate 3p7 release candidate 3p7 RC1 Oct 10, 2023
@sedghi sedghi closed this Oct 11, 2023
@sedghi sedghi deleted the release-candidate-3p7 branch May 16, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.