detect: absent keyword to test absence of sticky buffer #11295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 2224 It takes an argument to match only if the buffer is absent, or it can still match if the buffer is present, but we test the absence of some content
catenacyber
commented
Jun 11, 2024
| @@ -192,6 +192,11 @@ uint8_t DetectFileInspectGeneric(DetectEngineCtx *de_ctx, DetectEngineThreadCtx | |||
| SCLogDebug("tx %p tx_id %" PRIu64 " ffc %p ffc->head %p sid %u", tx, tx_id, ffc, | |||
| ffc ? ffc->head : NULL, s->id); | |||
| if (ffc == NULL) { | |||
| const bool eof = (AppLayerParserGetStateProgress(f->proto, f->alproto, tx, flags) > | |||
There was a problem hiding this comment.
Do we have a good use case for files ?
|
Information: ERROR: QA failed on SURI_TLPW1_suri_time. ERROR: QA failed on SURI_TLPR1_suri_time.
Pipeline 21060 |
|
Continued in #11298 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/2224
Describe changes:
absentkeyword to match on absent bufferSV_BRANCH=OISF/suricata-verify#1912
#11190 with complete overhaul by not changing the default negation behavior, but just adding a keyword
absentStill need some tests for frames and http.request_body