detect: absent keyword to test absence of sticky buffer #11298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 2224 It takes an argument to match only if the buffer is absent, or it can still match if the buffer is present, but we test the absence of some content
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11298 +/- ##
==========================================
+ Coverage 82.45% 82.46% +0.01%
==========================================
Files 961 961
Lines 251710 251866 +156
==========================================
+ Hits 207552 207708 +156
Misses 44158 44158
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
ERROR: ERROR: QA failed on build_asan. Pipeline 21069 |
|
Information: QA ran without warnings. Pipeline 21072 |
jasonish
reviewed
Jun 12, 2024
| ------ | ||
|
|
||
| The keyword ``absent`` checks that a sticky buffer does not exist. | ||
| It can take an argument "only" to match only on absent buffer : |
There was a problem hiding this comment.
What about http.referer; absent; sid:1; rev:1;?
There was a problem hiding this comment.
Tried that, but apparently a signature keyword must have either an argument or none, cannot be optional...
|
Clean in #11301 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/2224
Describe changes:
absentkeyword to match on absent bufferSV_BRANCH=OISF/suricata-verify#1914
#11295 with more complete tests and fixes