Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smb hashmap/v9 #12036

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Smb hashmap/v9 #12036

wants to merge 11 commits into from
+551 −410

Commits on Oct 25, 2024

  1. rust: update crates

    @victorjulien
    victorjulien committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    927e1b3 View commit details
    Browse the repository at this point in the history

  2. smb2: use if let for read/write parsing

    @victorjulien
    victorjulien committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    4f4726f View commit details
    Browse the repository at this point in the history

  3. smb: update to GAP handling 

    Don't tag the session as gap'd when the GAP is in a precise location:

1. in "skip" data, where the GAP just fits the skip data

2. in file data, where we pass the GAP on to the file

This reduces load of GAP post-processing that is unnecessary in these
case.
    @victorjulien
    victorjulien committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    f901bd9 View commit details
    Browse the repository at this point in the history

  4. smb2: remove filename on close 

    Ticket: OISF#5672.
    @victorjulien
    victorjulien committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    8331313 View commit details
    Browse the repository at this point in the history

  5. smb1: remove name on close 

    Ticket: OISF#5672.
    @victorjulien
    victorjulien committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    77b38d6 View commit details
    Browse the repository at this point in the history

  6. smb: use lru for guid2name map; rename 

    Use `lru` crate. Rename to reflect this.

Add `app-layer.protocols.smb.max-guid-cache-size` to control the max
size of the LRU cache.

Ticket: OISF#5672.
    @victorjulien
    victorjulien committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    770e59b View commit details
    Browse the repository at this point in the history

  7. smb: use lru for ssn2vecoffset_map; rename 

    Rename to read_offset_cache.

Add `app-layer.protocols.smb.max-read-offset-cache-size` option to
control the limit.

Ticket: OISF#5672.
    @victorjulien
    victorjulien committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    64e314d View commit details
    Browse the repository at this point in the history

  8. smb: use lru for ssn2tree; rename 

    Turn the map mapping the smb session key to smb tree into a lru cache,
limited to 1024 by default.

Add `app-layer.protocols.smb.max-tree-cache-size` option to control the
limit.

Ticket: OISF#5672.
    @victorjulien
    victorjulien committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    fe9a98f View commit details
    Browse the repository at this point in the history

  9. smb: use lru for ssnguid2vec_map; rename 

    Reimplement the ssnguid2vec_map HashMap as a LruCache.

Since this is a DCERPC record cache, name it as such.

Default size is 128. Can be controlled by
`app-layer.protocols.smb.max-dcerpc-frag-cache-size`.

Ticket: OISF#5672.
    @victorjulien
    victorjulien committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    2bcb393 View commit details
    Browse the repository at this point in the history

  10. smb: use lru for ssn2vec_map 

    Generic ssn2vec_map was a HashMap used for mapping session key to
different types of vector data:
- GUID
- filename
- share name

Turn this into a bounded LruCache. Rename to ssn2vec_cache.

Size of the cache is 512 by default, and can be configured using:

`app-layer.protocols.smb.max-session-cache-size`

Ticket: OISF#5672.
    @victorjulien
    victorjulien committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    e79c820 View commit details
    Browse the repository at this point in the history

  11. doc/userguide: document smb cache size limit options 

    Ticket: OISF#5672.
    @victorjulien
    victorjulien committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    2684860 View commit details
    Browse the repository at this point in the history