Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft: Build-info: remove obsolete rust support line-v1 #12038

Closed

Conversation

Nancyenos
Copy link
Contributor

@Nancyenos Nancyenos commented Oct 25, 2024

Ticket: #6705

Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

Our Contribution agreements:

Link to ticket: https://redmine.openinfosecfoundation.org/issues/6705

Describe changes:

  • Remove obsolete rust support line-v1
  • Running ./src/suricata --build-info no longer shows rust support but am not sure if this is all that was recquired for this ticket

@Nancyenos Nancyenos changed the title Build-info: remove obsolete rust support line-v1 draft: Build-info: remove obsolete rust support line-v1 Oct 25, 2024
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.41%. Comparing base (89aa525) to head (778a39e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12038      +/-   ##
==========================================
- Coverage   83.42%   83.41%   -0.01%     
==========================================
  Files         910      910              
  Lines      257642   257642              
==========================================
- Hits       214934   214917      -17     
- Misses      42708    42725      +17     
Flag Coverage Δ
fuzzcorpus 61.57% <ø> (ø)
livemode 19.41% <ø> (-0.01%) ⬇️
pcap 44.46% <ø> (-0.04%) ⬇️
suricata-verify 62.76% <ø> (-0.01%) ⬇️
unittests 59.37% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running ./src/suricata --build-info no longer shows rust support but am not sure if this is all that was recquired for this ticket

That's all that is needed, I think. :)

Could you please readjust you commit message and use configure: prefix instead of Build-info?

Note: Since you have made a few successful (🎉 ) contributions already, might be good to look at tickets that don't have Good First Issue label. These are really for when you're doing your first PR contribution.

@Nancyenos
Copy link
Contributor Author

Running ./src/suricata --build-info no longer shows rust support but am not sure if this is all that was recquired for this ticket

That's all that is needed, I think. :)

Could you please readjust you commit message and use configure: prefix instead of Build-info?

Note: Since you have made a few successful (🎉 ) contributions already, might be good to look at tickets that don't have Good First Issue label. These are really for when you're doing your first PR contribution.

Thank you @inashivb and well noted

@Nancyenos
Copy link
Contributor Author

work continued in #12040

@Nancyenos Nancyenos closed this Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants