Next/20211213/v3 #6705
Merged
Next/20211213/v3 #6705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of storing a name and description as a pointer in DetectBufferType store them in fixed size arrays. This is in preparation of runtime registration of buffer types, where a constant name/desc is not available.
Use util function in all code needing the ack'd data.
Ticket: 4857 If a pattern such as GET is seen ine the beginning of the file transferred over ftp-data, this flow will get recognized as HTTP, and a HTTP state will be created during parsing. Thus, we cannot override directly alproto's values This solves the segfault, but not the logical bug that the flow should be classified as FTP-DATA instead of HTTP
Codecov Report
@@ Coverage Diff @@
## master #6705 +/- ##
==========================================
+ Coverage 77.12% 77.17% +0.04%
==========================================
Files 613 613
Lines 185666 185593 -73
==========================================
+ Hits 143194 143223 +29
+ Misses 42472 42370 -102
Flags with carried forward coverage won't be shown. Click here to find out more. |
Merged
This was referenced Dec 14, 2021
Closed
Nancyenos
added a commit
to Nancyenos/suricata
that referenced
this pull request
Oct 25, 2024
2 tasks
Nancyenos
added a commit
to Nancyenos/suricata
that referenced
this pull request
Oct 26, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6699 #6667 #6651
plus some misc commits