tee.bin partitioning #1621
Merged
tee.bin partitioning #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this breaks the 64-bit pager on HiKey (32 bits is OK though). I'll take a closer look. |
|
Found the problem, a fix is added in this PR. |
|
Good catch, problem fixed indeed.
|
|
In "core: reduce init size", I suggest |
Makes functions that need to be excluded from unpaged and init parts of the TEE binary weak. When building the dependency graph for init and unpaged parts an empty version of those functions (from core/arch/arm/kernel/link_dummies.c) are used instead. Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
Reduces unpaged size by excluding __thread_std_smc_entry() from the unpaged graph. Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
Dramatically reduces init size by excluding __wq_rpc() from the init graph. Without __wq_rpc() in the init grapth, the entire LibTomCrypt is removed for the init graph. Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU v8 pager) Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
The entire range of memory touched during init need to be invalidated in the caches before enabling the caches. Prior to this patch with CFG_WITH_PAGER=y the caches where only invalidated until __init_end which isn't enough, memory up to __tmp_hashes_end is actually touched. With this patch the range is increased to __tmp_hashes_end which is the same as is used in the arm32 code. Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (HiKey 32/64) Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org> Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (Hikey 64-bit pager) Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
|
Tags applied, commit message updated as suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.