Proxy generation fails if magic methods are marked as final.

[jmalloc]

The PDO::__wakeup() method is marked as final, but it looks like the final flag of magic methods is not checked as it is for other methods. Hence the code below produces a fatal error:

$factory = new ProxyManager\Factory\LazyLoadingValueHolderFactory();
$factory->createProxy(
    'PDO',
    function () {}
);

Fatal error: Cannot override final method PDO::__wakeup() in ... on line 5

[Ocramius]

@jmalloc not sure if I should just deny proxying (as I can't ensure proxy invariants in this case) or silently skip the method. Thoughts?

[jmalloc]

That's a tough call to make! In regards to __wakeup, specifically, I'd say there's value in allowing the proxies to be created as there's plenty of reason to use a proxy without ever having to serialize/unserialize it (unless this is used internally somewhere?).

[Ocramius]

Alright: I'll try fixing this for 1.0.0
On Oct 20, 2014 2:19 AM, "James Harris" notifications@github.com wrote:

That's a tough call to make! In regards to __wakeup, specifically, I'd
say there's value in allowing the proxies to be created as there's plenty
of reason to use a proxy without ever having to serialize/unserialize it
(unless this is used internally somewhere?).

—
Reply to this email directly or view it on GitHub
#187 (comment)
.

[Ocramius]

Solved in #189

[jmalloc]

Awesome, thanks!

[githoober]

Hi @Ocramius,

my question is whether a final method should instantiate a proxy. I have a strong feeling that it should. And because it cannot be overridden a different mechanism should be implemented to make it work.
Any thoughts on that?

[Ocramius]

And because it cannot be overridden a different mechanism should be implemented to make it work.

It simply cannot be done. final is final, and that's perfectly ok. If you need to mock/proxy final classes, then you want to proxy their interface instead.

[githoober]

I agree with an argument about creating a proxy for a final class, but my question is about a regular not final class that can contain some final methods. Since a proxy should be instantiated by any public method, this should also include final public methods. Since overriding is not working in this case, a different way could be researched instead.

[Ocramius]

@githoober that depends on the proxy implementation. Right now, we already proxy only methods that can be overridden

In some proxy implementations, the methods need to be all proxied, and therefore it is not possible to proceed with the code generation.