-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation on github pages #182
Conversation
@@ -0,0 +1,270 @@ | |||
<!DOCTYPE html> | |||
<!--[if lt IE 7]> <html class="no-js lt-ie9 lt-ie8 lt-ie7" id="top"> <![endif]--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can skip anything IE...
- Link the new page in all places needed
- Put links where is necessary for new documentation page
- Remove unecessary headers for IE old versions (nedded by @Ocramius) - Modify metatags to optmize searches robots - Add links to menu on all pages
- Fix footer on css - Reduce css rules
- Put right links on `index.html` section for `Access interceptor value holder` - Create documentation page for `Tuning the ProxyManager for production`
- Put link on `index.html`
- Fix favicon path in all html files
@Ocramius need review. |
Few issues that I found: Homepage
MenuThe menu is quite nice, but the Top navThe github link in the top nav does not respect CaseSEnsItIvity of the URL, and the GITHUB link may be replaced with the octocat SVG. Header:This header seems to be repeated on all pages: the homepage should be enough. Eventually, consider adding the logo at the top of the menu instead. Credits:May want to add a list of contributors here, including yourself Copyright:Currently doesn't display anything: should contain a plaintext copy (may use code highlighting) of the MIT license. Talk:May want to add a page with the talk at https://www.youtube.com/watch?v=Ka8wlV8M6Vg Footer:
|
Also needed: an |
Can you also rename |
- Put video and description on `index.html` - Fix links to `copyright`
@Ocramius done |
Total issues resolved: **17** - [108: Fix windows path length limitations](#108) - [172: Alternate hotfix for #108 - windows path length limitations](#172) - [178: Verify type-safety with `self` and `static` type-hints](#178) - [180: #178 - `self` type safety check](#180) - [181: Documentation should be released on github pages on the `gh-pages` branch.](#181) - [182: Documentation on github pages](#182) - [187: Proxy generation fails if magic methods are marked as final](#187) - [189: Bugfix - cannot override final methods ( #187 )](#189) - [190: [WIP] [EXPERIMENTAL] Codegen should not trigger fatals](#190) - [191: Put link of documentation on README.md and Close #185](#191) - [193: [WIP] Codegen errors](#193) - [194: Code-generation fatal error prevention](#194) - [195: Blogpost about 1.0.0, 2.0.0 and stability frames](#195) - [196: Define maintainance time-frames (stable/oldstable/etc)](#196) - [198: Highlighting the code examples](#198) - [199: Removed unused `ReflectionMethod` import](#199) - [202: #196 - adding document with expected stability time-frames](#202)
Reference to #181