Support configuring script pod resource requirements #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevjt
approved these changes
Jul 10, 2024
source/Octopus.Tentacle/Kubernetes/KubernetesScriptPodCreator.cs
Outdated
Show resolved
Hide resolved
liam-mackie
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
LGTM! Thanks for the 🍐 on the review.
For posterity - we talked about validating the resource requests and limits, but there was no easy way to do this in the C# k8s client. In addition, the error returned when this happens is verbose and points to the issue fairly well.
liam-mackie
approved these changes
Jul 10, 2024
Co-authored-by: Kevin Tchang <151479559+kevjt@users.noreply.github.com>
APErebus
commented
Jul 10, 2024
| //if we can't parse the JSON, fall back to the defaults below and warn the user | ||
| log.WarnFormat(e, message); | ||
| //write a verbose message to the script log. | ||
| tentacleScriptLog.Verbose(message); |
There was a problem hiding this comment.
Minor addition, I now write a verbose message back to the script log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #979
Background
A customer appears to be having resource contention with a large number of script pods. They would like to be able to modify the resource requirements of script pods.
Results
Adds support for a new environment variable
OCTOPUS__K8STENTACLE__PODRESOURCEJSONwhich contains the serialized resource requirements provided by the helm chart in OctopusDeploy/helm-charts#225We then deserialize this to a
V1ResourceRequirementsand use itShortcut story: [sc-82857]
How to review this PR
Quality ✔️
Pre-requisites