-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support configuring script pod resource requirements #225
Support configuring script pod resource requirements #225
Conversation
🦋 Changeset detectedLatest commit: b178a1e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the 🍐 on the review.
For posterity - the test should pass once the tentacle PR is merged and the build is available on dockerhub.
A customer appears to be having resource contention with a large number of script pods. They would like to be able to modify the resource requirements of script pods.
This PR adds a new values node in the
scriptPods
section. Theseresources
are then serialized to JSON and passed to theagent-tentacle
container as an environment variable. This is consumed by the change in OctopusDeploy/OctopusTentacle#977Tested locally with
resulted in tentacle env var
resulted in script pods config