Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuring script pod resource requirements #225

Merged
merged 8 commits into from
Jul 10, 2024

Conversation

APErebus
Copy link
Contributor

@APErebus APErebus commented Jul 9, 2024

A customer appears to be having resource contention with a large number of script pods. They would like to be able to modify the resource requirements of script pods.

This PR adds a new values node in the scriptPods section. These resources are then serialized to JSON and passed to the agent-tentacle container as an environment variable. This is consumed by the change in OctopusDeploy/OctopusTentacle#977

Tested locally with

--set scriptPods.resources.limits.cpu="150m" `
--set scriptPods.resources.limits.memory="250Mi" `
--set scriptPods.resources.requests.cpu="50m" `
--set scriptPods.resources.requests.memory="150Mi" 

resulted in tentacle env var

image

resulted in script pods config

image

Copy link

changeset-bot bot commented Jul 9, 2024

🦋 Changeset detected

Latest commit: b178a1e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
kubernetes-agent Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@APErebus APErebus marked this pull request as ready for review July 10, 2024 00:16
Copy link
Contributor

@liam-mackie liam-mackie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the 🍐 on the review.
For posterity - the test should pass once the tentacle PR is merged and the build is available on dockerhub.

@APErebus APErebus merged commit 7999cbb into release/kubernetes-agent/v1 Jul 10, 2024
7 checks passed
@APErebus APErebus deleted the ap/script-pod-resources branch July 10, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants