Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: project create #115
feat: project create #115
Changes from 14 commits
f3e7fca
c283bde
9653db3
88b416b
98d10ca
f0a5a76
5f50b52
d55ff9b
16acf77
5a94d1f
4d79676
4085d57
b0311f2
15f4428
86c5baa
c86ad72
5d97470
b00c777
086a0aa
cf38f22
a69591d
f79b8f7
2c0d949
57d6f46
487aaa7
91a4f0c
3b5aa46
ec7cbd3
2f2b6d2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q for @domenicsim1
Given that this isn't a command itself, should it go under the
cmd
directory structure, or should it go under just pkg or pkg/somethingelse?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe, although it is suppose to be the basis of cmds. Not sure yet, happy to leave it for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I completely understand we're trying to fit within the patterns and idioms of golang... but
Dependable
is perhaps too vague. Does this mean it's never going to let us down? 🤣There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps
Dependencies
might be a bit of a vague name here? My immediate thought is "which dependencies does this struct represent? who depends on them and why?"From a quick look, it appears as though this struct is meant to carry services (client, asker) and options (space, noprompt) that are commonly used across many commands? If so, some possible naming suggestions?
ServicesAndOptions
CommandContext
CliCommandContext
CommandCommonData
StandardCommandProperties
CommonCommandProperties
GeneralCommandProps
... something to think about anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tag @slewis74
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure I am happy with name. Suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found when doing
release create
that it's referred to as "Version Controlled" in almost all places in the octopus codebase and web portal and other documentation. E.g. you'll see documentation snippets like "for a version controlled project...", so I used that term there.So, within the CLI there's precedent to call this "versionControlled".
On the other hand, the "brand name" that keeps showing up on twitter/linkedin/customer forums is always Config As Code, so 🤷 ? tag @jbristowe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC both
Required
andMinLength(1)
do the same job, and we probably don't need both of them.I ran into this when selecting environments for release deployment, which is a multi-select with min-items(1); Required did the same job but produced a better error message so I used that instead