Newsletter sent with a "New TV" block but no item below

[sephrat]

Describe the bug
Just received my weekly newsletter with a "New TV" block without any item below.
I think there are two inherent issues:

• The block shouldn't display at all instead of showing without any item.
• One item should have popped in the list. The lead I have so far: it was added to Emby a few hours before the newsletter job, but is not referenced as "Available" in Ombi yet. Maybe there's an issue with the newsletter when Emby and Ombi are out of sync?
  Edit: actually there's a second item that should have popped and is properly synced in Ombi, so that's not it. Will try to find more useful info.

Screenshots

Logs (Logs directory where Ombi is located)

2021-12-17 12:00:00.001 +01:00 [Debug] Calling Execute on job System.INewsletterJob
2021-12-17 12:00:00.005 +01:00 [Debug] Trigger instruction : NoInstruction
2021-12-17 12:00:17.923 +01:00 [Error] StatusCode: NotFound, Reason: Not Found, RequestUri: http://api.themoviedb.org/3/find/?api_key=b8eabaf5608b88d0298aa189dd90bf00&external_source=imdb_id
2021-12-17 12:00:19.432 +01:00 [Error] StatusCode: NotFound, Reason: Not Found, RequestUri: http://api.tvmaze.com/lookup/shows?thetvdb=82890
2021-12-17 12:00:19.480 +01:00 [Error] StatusCode: NotFound, Reason: Not Found, RequestUri: http://api.tvmaze.com/lookup/shows?thetvdb=412366

Ombi Version (please complete the following information):

• Version 4.7.8
• Media Server : Emby

[github-actions]

Hi!

Thanks for the issue report. Before a real human comes by, please make sure you used our bug report format.

Have you looked at the wiki yet? https://docs.ombi.app/

Before posting make sure you also read our FAQ.

Make the title describe your issue. Having 'not working' or 'I get this bug' for 100 issues, isn't really helpful.

If we need more information or there is some progress we tag the issue or update the tag and keep you updated.

Thanks!

Ombi Bot.

[sephrat]

Ah, I think I see it. The newsletter generates the "New TV" block when there are new episodes but the individual episodes won't show if no info could be found from TVMaze API.

Ombi/src/Ombi.Schedule/Jobs/Ombi/NewsletterJob.cs

Lines 1069 to 1073 in 5e140ab

	var info = await _tvApi.ShowLookupByTheTvDbId(tvdbId);
	if (info == null)
	{
	continue;
	}

We need to generate the "TV block" only when we know for sure some content will be generated after.
On top of that, shouldn't we move from TVMaze to TMDB to be consistent with the rest of the app?

[tidusjar]

Looks like that's an area we missed migrating from from TvMaze