-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: multiomics modules #228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for now! Added notes for the dataset refactoring to be done in the next PR
@@ -182,7 +183,7 @@ def __init__(self, subtask, data_dir="./data"): | |||
|
|||
def preprocess(self, kind='feature_selection', selection_threshold=10000): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO in a future PR: refactor dataset object to use the dance abstract dataset class, see ClusteringDataset
for example
No description provided.