Consider subset match valid for symbol lookups and completions #990
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the following code:
When passing
Opt
into symbol lookup or completion service, we will only returnOptions
, which is not the optimal user experience.In fact, this is not in line with the Visual Studio behavior, where in both symbol lookup and completion,
opt
returns all 3 possibilities.This PR changes a subset match of length longer than 1 to be valid when verifying symbol/completion subsequences, resulting in much better experience.