for single character completions, treat the completion list as incomplete #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm OK with doing this at 2 letters. In Visual Studio, note that we don't apply any substring filtering until at least two characters are typed. |
rchande
approved these changes
Oct 27, 2017
|
We do not have tests that specifically test |
great - it appeared so to me but I wasn't 100% sure. Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we now have OmniSharp/omnisharp-roslyn#990, which will offer good subsequence matching, we should treat completion lists for short words (empty and single letters) as incomplete. At the moment every completion list is considered complete and VS Code doesn't go back to the server for better matches as we type more characters.
This will force the editor to go again to the server with 2 letters, at which point the server will offer a much better result (as it will include the subsequence matches originally withheld for performance reasons). We may want to change that to 3 letters or more if the length of 2 is still too aggressive.