Fix iOS link error for apps consuming .nupkg for 4.0.0
#255
+24
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xamarin has limited support for `.xcframework` files, they do not have a built in working solution for NuGet packages yet. This works around the issue by including `OneSignal.xcframework` as-is in the `.nupkg`. It also includes a `.target` file which is setting to add the `OneSignal.xcframework` as a native reference. See the comment in the `Com.OneSignal.nuspec` file for more details. The items under `<NativeReference>` in `Com.OneSignal.targets` is from `OneSignal.iOS.Binding.csproj` in this repo. This was added based on the recommendations from: - xamarin/xamarin-macios#10819 (comment)
tanaynigam
approved these changes
Nov 22, 2021
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jkasten2)
Base automatically changed from
fix/ios_building_with_xcframework
to
4.0.0_release
November 22, 2021 19:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Xamarin has limited support for
.xcframeworkfiles, they do not have a built in working solution for NuGet packages yet. This works around the issue by includingOneSignal.xcframeworkas-is in the.nupkg. It also includes a.targetfile which is settings to add theOneSignal.xcframeworkas a native reference. See the comment in theCom.OneSignal.nuspecfile for more details.The items under
<NativeReference>inCom.OneSignal.targetsis fromOneSignal.iOS.Binding.csprojin this repo.This was added based on the recommendations from:
This change is