Fix iOS nuget XCFramework nested path copy reference #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our .nuspec places the `OneSignal.iOS.Binding\Com.OneSignal.targets` file under `build\Xamarin.iOS10\` in the package so inorder for it to access `contents` at the root it needs to go up two folder levels.
tanaynigam
approved these changes
Feb 8, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jkasten2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fixes "OneSignal.xcframework has an incorrect or unknown format and cannot be processed" error on 4.0.0-beta1+ on iOS builds due to wrong copy path for the root
contentsfolder whereOneSignal.xcframeworklives under.Details
Our
.nuspecplaces theOneSignal.iOS.Binding\Com.OneSignal.targetsfile underbuild\Xamarin.iOS10\in the package so in order for it to accesscontentsat the root it needs to go up two folder levels.PR #255 where this copy command was originally added had this path wrong.
Motivation
Fixes iOS build error reported by beta testers #262 (comment)
Scope
Effects all iOS builds.
Testing
Manual testing
Tested on Visual Studio Community 2019 for Mac and locally modifying
~/.nuget/packages/com.onesignal/4.0.0-beta2/build/Xamarin.iOS10/Com.OneSignal.targetsto confirm it fixes the build and runs on an iOS 14 device.This change is