[localprocessing] Fixed required packages versions #409
Conversation
setup.py
Outdated
| "openeo_pg_parser_networkx>=2023.1.2", | ||
| "openeo_processes_dask>=2023.3.0", | ||
| "openeo_pg_parser_networkx==2023.3.1", | ||
| "openeo_processes_dask[implementations]==2023.3.2", |
There was a problem hiding this comment.
Generally it's bad style to pin versions down to an exact version in setup.py.
It's common practice to use == in requirements.txt, but setup.py should be more liberal and typically just contain >= constraints.
Is there a particular reason to pin down the versions like that?
There was a problem hiding this comment.
I followed the suggestion of @LukeWeidenwalker, since he said that the next versions could introduce braking changes.
There was a problem hiding this comment.
@soxofaan I removed the == in setup.py and added a requirements.txt file just with those two packages. Makes sense or do we need to include more in that file?
|
FYI: I already cherrypicked the rioxarray constraint on master |
|
Ok, please note that rioxarray 0.13.0 is available only for Python 3.8+ |
|
Closing this PR, moving the changes to #411 |
Fixed required versions of openeo_pg_parser_networkx and openeo_processes_dask to the latest tested versions, to avoid incompatibilities and functionalities breaks due to updates.