Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[localprocessing] Fixed required packages versions #409

Closed
wants to merge 4 commits into from
Closed

[localprocessing] Fixed required packages versions #409

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
301d422
fixed versions
clausmichele Apr 3, 2023
002a08f
set min rioxarray version
clausmichele Apr 3, 2023
c407a16
added requirements.txt for localprocessing
clausmichele Apr 5, 2023
e8677ce
remove strict versions from setup.py
clausmichele Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@
]

localprocessing_require = [
"rioxarray",
"rioxarray>=0.13.0",
"pyproj",
"openeo_pg_parser_networkx>=2023.1.2",
"openeo_processes_dask>=2023.3.0",
"openeo_pg_parser_networkx==2023.3.1",
"openeo_processes_dask[implementations]==2023.3.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally it's bad style to pin versions down to an exact version in setup.py.
It's common practice to use == in requirements.txt, but setup.py should be more liberal and typically just contain >= constraints.

Is there a particular reason to pin down the versions like that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the suggestion of @LukeWeidenwalker, since he said that the next versions could introduce braking changes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soxofaan I removed the == in setup.py and added a requirements.txt file just with those two packages. Makes sense or do we need to include more in that file?

]


Expand Down