fix: The role displayed on the first Server in the Group area of the codis-fe is incorrect (#2350) #2387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…codis-fe is incorrect (OpenAtomFoundation#2350)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| <a ng-href="http://[[codis_addr]]/api/topom/group/info/[[server.server]]" target="_blank" class="btn btn-default btn-xs active" role="button">S</a> | ||
| <span ng-switch="$index"> | ||
| <a ng-switch-when="0" ng-href="http://[[codis_addr]]/api/topom/group/info/[[server.server]]" target="_blank" class="btn btn-default btn-xs active" role="button">Master</a> | ||
| <a ng-switch-default ng-href="http://[[codis_addr]]/api/topom/group/info/[[server.server]]" target="_blank" class="btn btn-default btn-xs active" role="button">Slave</a> |
Check warning
Code scanning / CodeQL
Potentially unsafe external link Medium
There was a problem hiding this comment.
codis-fe 原来的写法，建议暂时不做修改，因为页面有很多这样的写法。如果要需要，可以统一调整
| @@ -538,7 +538,10 @@ | |||
| </span> | |||
| </td> | |||
| <td> | |||
| <a ng-href="http://[[codis_addr]]/api/topom/group/info/[[server.server]]" target="_blank" class="btn btn-default btn-xs active" role="button">S</a> | |||
| <span ng-switch="$index"> | |||
| <a ng-switch-when="0" ng-href="http://[[codis_addr]]/api/topom/group/info/[[server.server]]" target="_blank" class="btn btn-default btn-xs active" role="button">Master</a> | |||
Check warning
Code scanning / CodeQL
Potentially unsafe external link Medium
There was a problem hiding this comment.
codis-fe 原来的写法，建议暂时不做修改，因为页面有很多这样的写法。如果要需要，可以统一调整
AlexStocks
approved these changes
Feb 7, 2024
chejinge
added a commit
that referenced
this pull request
Feb 7, 2024
* fix: codis-dashboard uses 100% cpu(#2332) (#2393) Co-authored-by: liuchengyu <liuchengyu@360.cn> * fix: The role displayed on the first Server in the Group area of the codis-fe is incorrect (#2350) (#2387) Co-authored-by: liuchengyu <liuchengyu@360.cn> --------- Co-authored-by: Chengyu Liu <chengyu_l@126.com> Co-authored-by: liuchengyu <liuchengyu@360.cn>
chejinge
added a commit
that referenced
this pull request
Feb 7, 2024
* fix: codis-dashboard uses 100% cpu(#2332) (#2393) Co-authored-by: liuchengyu <liuchengyu@360.cn> * fix: The role displayed on the first Server in the Group area of the codis-fe is incorrect (#2350) (#2387) Co-authored-by: liuchengyu <liuchengyu@360.cn> * fix: automatic fix master-slave replication relationship after master or slave service restarted (#2373, #2038, #1950, #1967, #2351)) (#2386) Co-authored-by: liuchengyu <liuchengyu@360.cn> * feat:add 3.5.3 changelog (#2395) * add 3.5.3 changelog --------- Co-authored-by: chejinge <chejinge@360.cn> --------- Co-authored-by: Chengyu Liu <chengyu_l@126.com> Co-authored-by: liuchengyu <liuchengyu@360.cn> Co-authored-by: chejinge <chejinge@360.cn>
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
…codis-fe is incorrect (OpenAtomFoundation#2350) (OpenAtomFoundation#2387) Co-authored-by: liuchengyu <liuchengyu@360.cn>
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
…codis-fe is incorrect (OpenAtomFoundation#2350) (OpenAtomFoundation#2387) Co-authored-by: liuchengyu <liuchengyu@360.cn>
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
* fix: codis-dashboard uses 100% cpu(OpenAtomFoundation#2332) (OpenAtomFoundation#2393) Co-authored-by: liuchengyu <liuchengyu@360.cn> * fix: The role displayed on the first Server in the Group area of the codis-fe is incorrect (OpenAtomFoundation#2350) (OpenAtomFoundation#2387) Co-authored-by: liuchengyu <liuchengyu@360.cn> --------- Co-authored-by: Chengyu Liu <chengyu_l@126.com> Co-authored-by: liuchengyu <liuchengyu@360.cn>
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
* fix: codis-dashboard uses 100% cpu(OpenAtomFoundation#2332) (OpenAtomFoundation#2393) Co-authored-by: liuchengyu <liuchengyu@360.cn> * fix: The role displayed on the first Server in the Group area of the codis-fe is incorrect (OpenAtomFoundation#2350) (OpenAtomFoundation#2387) Co-authored-by: liuchengyu <liuchengyu@360.cn> * fix: automatic fix master-slave replication relationship after master or slave service restarted (OpenAtomFoundation#2373, OpenAtomFoundation#2038, OpenAtomFoundation#1950, OpenAtomFoundation#1967, OpenAtomFoundation#2351)) (OpenAtomFoundation#2386) Co-authored-by: liuchengyu <liuchengyu@360.cn> * feat:add 3.5.3 changelog (OpenAtomFoundation#2395) * add 3.5.3 changelog --------- Co-authored-by: chejinge <chejinge@360.cn> --------- Co-authored-by: Chengyu Liu <chengyu_l@126.com> Co-authored-by: liuchengyu <liuchengyu@360.cn> Co-authored-by: chejinge <chejinge@360.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: The role displayed on the first Server in the Group area of the codis-fe is incorrect (#2350 )