Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: The role displayed on the first Server in the Group area of the codis-fe is incorrect (#2350) #2387

Merged
merged 1 commit into from
Feb 7, 2024
Merged

fix: The role displayed on the first Server in the Group area of the codis-fe is incorrect (#2350) #2387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion codis/cmd/fe/assets/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,10 @@
</span>
</td>
<td>
<a ng-href="http://[[codis_addr]]/api/topom/group/info/[[server.server]]" target="_blank" class="btn btn-default btn-xs active" role="button">S</a>
<span ng-switch="$index">
<a ng-switch-when="0" ng-href="http://[[codis_addr]]/api/topom/group/info/[[server.server]]" target="_blank" class="btn btn-default btn-xs active" role="button">Master</a>

Check warning

Code scanning / CodeQL

Potentially unsafe external link Medium

External links without noopener/noreferrer are a potential security risk.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codis-fe 原来的写法，建议暂时不做修改，因为页面有很多这样的写法。如果要需要，可以统一调整

<a ng-switch-default ng-href="http://[[codis_addr]]/api/topom/group/info/[[server.server]]" target="_blank" class="btn btn-default btn-xs active" role="button">Slave</a>

Check warning

Code scanning / CodeQL

Potentially unsafe external link Medium

External links without noopener/noreferrer are a potential security risk.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codis-fe 原来的写法，建议暂时不做修改，因为页面有很多这样的写法。如果要需要，可以统一调整

</span>
<span ng-switch="server.ha_status">
<span ng-switch-when="ha_master" style="color: darkgreen"
data-toggle="tooltip" data-placement="right" title="HA: MASTER">
Expand Down
Loading