Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] - Move extra_params warning to query.py #6259

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented Mar 27, 2024

  1. Why?

    • Unsupported parameter warnings were sent in the API because of FastAPI Depends always applying class defaults
  2. What? (1-3 sentences or a bullet point list):

    • Move the warning back to query, keep in the command runner the warning for unsupported parameters
  3. Impact

    NA

  4. Testing Done:

  • Same for API
# warn nothing is not valid
obb.equity.price.historical("AAPL", nothing=1)

# warn prepost is not valid for fmp, but is valid for yfinance
obb.equity.price.historical("AAPL", provider="fmp", prepost=True)

# warn nothing is not valid
# warn prepost is not valid for fmp, but is valid for yfinance
obb.equity.price.historical("AAPL", provider="fmp", nothing=1, prepost=True)

@github-actions github-actions bot added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Mar 27, 2024
@hjoaquim hjoaquim enabled auto-merge March 27, 2024 15:34
@hjoaquim hjoaquim added this pull request to the merge queue Mar 27, 2024
Merged via the queue into develop with commit 4b5787b Mar 27, 2024
10 checks passed
@IgorWounds IgorWounds deleted the bugfix/filter_extra_params branch March 31, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants