[BugFix] Add sort to tiingo equity historical

[hjoaquim]

1. Why?:

   • Tiingo requires the sort argument. The endpoint breaks without it.

2. What? (1-3 sentences or a bullet point list):

   • Added the sort argument.

3. Impact (1-2 sentences or a bullet point list):

   • 5 (positive UX impact fixing an unusable endpoint)

4. Testing Done:

   • Run the endpoint for tiingo, before and after the fix.

[deeleeramone]

Isn't this a fruitless effort to expose this param? Sorting occurs by date, ALWAYS for this endpoint, and results are always sorted in the same direction, ascending for every provider.

[hjoaquim]

I got this error without using the sort:
"Error: Sort column name is not a valid column"

So, apparently the sort needs to be explicit in the URL.

[deeleeramone]

How come it works for me right now, without this?

[deeleeramone]

The URL appears to work fine without a sort column.

https://api.tiingo.com/tiingo/daily/AAPL/prices?startDate=2023-03-27&endDate=2024-03-27&resampleFreq=monthly&token=

[deeleeramone]

I'm not able to recreate the issue you raise on the develop branch:

obb.equity.price.historical("AAPL", provider="tiingo").to_df()

[hjoaquim]

Just figured that #6259 fixes this issue - the URL is built differently and then the sort is not mandatory (apparently). Not sure if we should keep it anyway.
@deeleeramone @montezdesousa

[deeleeramone]

Just figured that #6259 fixes this issue - the URL is built differently and then the sort is not mandatory (apparently). Not sure if we should keep it anyway. @deeleeramone @montezdesousa

There is no purpose for a sort field, time series data all needs to be the same from all providers - sorted by date/ascending. If users want to sort by the closing price, they will need to do that post-request..