-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Add sort
to tiingo equity historical
#6261
Conversation
@@ -44,6 +44,24 @@ class TiingoEquityHistoricalQueryParams(EquityHistoricalQueryParams): | |||
_frequency: Literal["daily", "weekly", "monthly", "annually"] = PrivateAttr( | |||
default=None | |||
) | |||
sort: Literal[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this a fruitless effort to expose this param? Sorting occurs by date, ALWAYS for this endpoint, and results are always sorted in the same direction, ascending for every provider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got this error without using the sort:
"Error: Sort column name is not a valid column"
So, apparently the sort
needs to be explicit in the URL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come it works for me right now, without this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just figured that #6259 fixes this issue - the URL is built differently and then the |
There is no purpose for a sort field, time series data all needs to be the same from all providers - sorted by date/ascending. If users want to sort by the closing price, they will need to do that post-request.. |
Why?:
sort
argument. The endpoint breaks without it.What? (1-3 sentences or a bullet point list):
sort
argument.Impact (1-2 sentences or a bullet point list):
Testing Done: