Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand and improve BeamDyn unit tests #560

Merged
merged 9 commits into from
Oct 14, 2020

Conversation

michaelasprague
Copy link
Contributor

Expanded unit test for BD_diffmtc; BD_diffmtc evaluates shape functions and their derivatives at points in [-1,1]
Converted single-subroutine test to module with two test routines.
Added a 5-node test problem more closely aligned with usage.
Also fixed call to diffmtc in original 2-node problem
Ready to be merged; all tests passed

Fixed call to diffmtc in original 2-node problem
Copy link
Collaborator

@rafmudaf rafmudaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.
Is Mathematica the only practical choice for a script to check the results? Octave or Python would be more convenient, not may not have a LengendreP function.

modules/beamdyn/tests/test_tools.F90 Outdated Show resolved Hide resolved
@rafmudaf rafmudaf changed the title Added test for BD_diffmtc (5-node problem) Expand and improve BeamDyn unit tests Oct 14, 2020
@rafmudaf rafmudaf merged commit a149328 into OpenFAST:dev Oct 14, 2020
@michaelasprague michaelasprague deleted the feature/bd_review branch October 15, 2020 20:12
@rafmudaf rafmudaf mentioned this pull request Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants