-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand and improve BeamDyn unit tests #560
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed call to diffmtc in original 2-node problem
rafmudaf
approved these changes
Oct 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
Is Mathematica the only practical choice for a script to check the results? Octave or Python would be more convenient, not may not have a LengendreP function.
ashesh2512
approved these changes
Oct 8, 2020
…0 for a 5-node curved element
rafmudaf
requested changes
Oct 8, 2020
…n in BeamDyn to simplify call
rafmudaf
changed the title
Added test for BD_diffmtc (5-node problem)
Expand and improve BeamDyn unit tests
Oct 14, 2020
rafmudaf
force-pushed
the
feature/bd_review
branch
from
October 14, 2020 15:44
83875e0
to
4c5ce54
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanded unit test for BD_diffmtc; BD_diffmtc evaluates shape functions and their derivatives at points in [-1,1]
Converted single-subroutine test to module with two test routines.
Added a 5-node test problem more closely aligned with usage.
Also fixed call to diffmtc in original 2-node problem
Ready to be merged; all tests passed