-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v2.5.0 #630
Merged
Release v2.5.0 #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InflowWind driver: ---- - functionality: - added option to convert file formats - input file changes: - added section for file conversion options - moved dt after timeStart (before summary stuff) - removed inflowWind setup section header - skip reading GridCtrCoord, GridD{x|y|z}, and GridN{x|y|z} lines if they aren't going to be used (and don't print them in summary file) InflowWind: --- - added code to include vertical flow angle (to rotate FF wind boxes vertically, too) - added base FF wind module so TurbSim, Bladed, and HAWC2 formats can use common code (all three formats use the same base code for interpolation, mean wind speed, etc) - added LHR rule for Bladed-generated winds - option for native Bladed file formats - return 0 wind speed at and below the ground height (z=0) instead of producing an error
- added omega to UA driver time-series file - added UAMod=4 (HGM model); linearization is incomplete - added DBMET_Mod=3 (continuous form of constant tau); linearization is incomplete - reorganized loops in BEM CalcOutput and UpdateStates for ease of reading/calculations - NEED TO CHECK the Cp/Cavit stuff!!! - added C_lalpha parameter to airfoil input file - NWTC Library: fix fatal issue if ever calling WrOver with more than ConRecL-1 characters - Allow AeroDyn driver to read time-history file as input - Many AeroDyn driver (all output is in one file)
added option to blend BEM/non-BEM solution when the TSR is lower than 2. BEM is totally off when TSR is <= 1
Default has changed from 20 Hz to 0.5 NEED TO DOCUMENT THIS!!!!!
- also a couple of additional robustness checks on DBEMT CCSD (alphaE and Tu)
…g time variable double-precision at all times.
These get inherited from FASTlib, and it seems to be bothering newer version of Visual Studio (trying to link the FAST executable with the Registry executable)
- Add continuous state for UA in FVW - change not-Fortran2003 `norm2()` to `TwoNorm()` - change precision in {x|y|z}_hat_disk to 8-byte - remove iBladeNode and iBlade from FVW%m_UA - update `UA_UpdateState_Wrapper` to call UA routines with appropriate arguments - attempt to call UA_UpdateStates and UA_CalcOutput with correct inputs (NEEDS A REVIEW!!!) - CHANGED dynamic cl, cd, cm when UA is called - fixed some error handling in `SetOutputsFromFVW`
- removed extra solution files - modified existing ones with Registry not using Release|Win32 configurations
will need to be updated again soon
The GemoPhi output will be a number between 0 (BEM only) and 1 (no BEM) that indicates if BEM has been turned off due to either no valid value of phi error from the BEM solution or a gradual turning off because TSR is less than 2.
Fixes issue #620 The code uses size(Ary) on an Ary that is not necessarily allocated. Now it is allocated to size 0 if there are no continuous states, which should fix the issues with using the size() function.
…ing (#616) * Simulink interface: fix potential memory leak and error handling * fix TRANSFER statement * fix typo
#627) If multiple input tables exist within an airfoil input file, the logic for setting the size of the Coefs array would result in extra columns for all tables > 1. This caused segfaults within the CubicSplineInitM routine with certain compilers (gfortran 9).
rafmudaf
requested review from
ebranlard,
michaelasprague,
andrew-platt and
jjonkman
January 13, 2021 22:07
ebranlard
approved these changes
Jan 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks all good to me.
andrew-platt
approved these changes
Jan 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
This pull request merges dev into master for a tagged release, v2.5.0. See below for the proposed change log.
Related issue, if one exists
None
Impacted areas of the software
See the change log below.
Test results, if applicable
The baseline results have changed since the last release. See the r-test pull requests for more information.
General
In v2.5.0, the
master
branch will becomemain
and this will serve as the "trunk" or primary branch for OpenFAST. This is in line with current best practices in naming conventions (see here).AeroDyn
BeamDyn
FAST Library
HydroDyn
InflowWind
MoorDyn
NWTC Library
Simulink
Documentation
Build system
Testing