Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker: set or lookup the collections adaptor version #804

Merged
merged 6 commits into from
Oct 23, 2024

Conversation

josephjclark
Copy link
Collaborator

Short Description

This PR levelsup the worker to know about which version of the collections adaptor to be used.

You can pass in a version explicitly, via the cli or env var. If no version is provided, the server will look up the latest version on npm.

This arises because of #462, where in the worker needs to know a specific adaptor version to autoinstall (using latest all the time just doesn't work very well).

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our Responsible AI Policy

@josephjclark josephjclark mentioned this pull request Oct 23, 2024
@josephjclark
Copy link
Collaborator Author

An integration test has started failing, something to do with the jwt. It's actually faiing for me on master too.

I'm going to merge this and then fix it on the other branch (if it doesn't go away)

@josephjclark josephjclark merged commit 2ac954e into release/collections Oct 23, 2024
4 of 6 checks passed
@josephjclark josephjclark deleted the collections-version branch October 23, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant