Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections #801

Merged
merged 59 commits into from
Oct 30, 2024
Merged

Collections #801

merged 59 commits into from
Oct 30, 2024

Conversation

Support multiple adaptors in the compiler
compiler: don't extract common exports
@josephjclark
Copy link
Collaborator Author

@stuartc I think this is done.

First job tomorrow is to try it against lightning and see how it holds up.

I don't know if you want to review anything. If you do, check the merged PRs referenced in the description - you'll go insane trying to understand this PR all in one go!

@josephjclark
Copy link
Collaborator Author

Two problems have crept in today:

  1. fn is being imported twice by the compiler. But I fixed this last week!
  2. TypeError: import_undici2.default.client is not a constructor when the mock is disabled

@josephjclark
Copy link
Collaborator Author

Tempted to drop in a fix for #806 here too, because it'll really help testing

@josephjclark josephjclark merged commit 451a3fd into main Oct 30, 2024
6 checks passed
@josephjclark josephjclark deleted the release/collections branch October 30, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

integration tests: write a test against collections
1 participant