Remove declared properties accessed by magic getter in Paypal Config

[elidrissidev]

Description (*)

In #2554, properties which were being set dynamically were added as class properties to support PHP 8.2. However in the case of app/code/core/Mage/Paypal/Model/Config.php, there is a magic getter (conveniently hidden in the center of the file 👀) which was accessing the properties from the paypal configuration which never gets called if the property is already declared on the class.

Related Pull Requests

1. See phpstan: fixed "Access to an undefined property" #2554

Fixed Issues (if relevant)

1. Fixes Problem during checkout with paypal express after upgrade from 19.4.16 to 19.4.19 #2756

Manual testing scenarios (*)

1. Paypal checkout should now be working as normal.

Questions or comments

app/code/core/Mage/Paypal/Model/Config.php will need to be refactored to get rid of dynamic properties assignment, but as that can take more time and can potentially be breaking, I choose to just undo that change until we decide later.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[github-actions]

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit a559a55. ± Comparison against base commit 73b970d.