Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP 8.2] Fixed some deprecation warnings #3155

Merged
merged 10 commits into from
Apr 11, 2023
Merged

[PHP 8.2] Fixed some deprecation warnings #3155

merged 10 commits into from
Apr 11, 2023

Conversation

fballiano
Copy link
Contributor

In #3152 @ADDISON74 found out some PHP 8.2 deprecation warnings, this PR should fix them.

Note: at the moment it still doesn't fix the problems with Mage_Paypal_Model_Config that apparently were introduced with #2759

Related Pull Requests

  1. Remove declared properties accessed by magic getter in Paypal Config #2759

Fixed Issues

  1. Fixes Lots of errors in the log files #3152

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Eav Relates to Mage_Eav Component: Rule Relates to Mage_Rule Component: SalesRule Relates to Mage_SalesRule Component: Widget Relates to Mage_Widget Template : admin Relates to admin template labels Apr 9, 2023
@ADDISON74 ADDISON74 mentioned this pull request Apr 10, 2023
Closed
fballiano and others added 4 commits April 10, 2023 09:25
@fballiano @kiatng
Update app/code/core/Mage/Eav/Model/Entity/Attribute/Source/Table.php
2f18a25 
but in this case if value is 0 then if would be treated as false and would be wrong no?

Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
@fballiano @kiatng
Update app/code/core/Mage/Rule/Model/Condition/Abstract.php
804f67b 
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
@fballiano
[PHP 8.2] Fixed some deprecation warnings
2776634
@fballiano
[PHP 8.2] Fixed some deprecation warnings
763687d
@github-actions github-actions bot added the Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches label Apr 10, 2023
@github-actions github-actions bot added Component: Sales Relates to Mage_Sales and removed Component: SalesRule Relates to Mage_SalesRule labels Apr 10, 2023
ADDISON74
ADDISON74 approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@ADDISON74 ADDISON74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it and I will make a list with the warnings left behind we still get in the log files.

@fballiano fballiano merged commit c2f7909 into OpenMage:main Apr 11, 2023
@fballiano fballiano deleted the php82 branch April 11, 2023 10:10
@Flyingmana Flyingmana mentioned this pull request Oct 5, 2023
Closed
kiatng added a commit to kiatng/magento-lts that referenced this pull request Oct 11, 2023
@fballiano @kiatng
[PHP 8.2] Fixed some deprecation warnings (OpenMage#3155)
3c8db5d 
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
@kiatng kiatng mentioned this pull request Oct 11, 2023
Merged
Flyingmana pushed a commit that referenced this pull request Oct 25, 2023
@kiatng @fballiano
[PHP 8.2] Fixed some deprecation warnings (#3155) (#3592)
876519d 
Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elidrissidev elidrissidev elidrissidev left review comments

@kiatng kiatng kiatng approved these changes

@ADDISON74 ADDISON74 ADDISON74 approved these changes

Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches Component: Eav Relates to Mage_Eav Component: Rule Relates to Mage_Rule Component: Sales Relates to Mage_Sales Component: Widget Relates to Mage_Widget Template : admin Relates to admin template
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lots of errors in the log files
4 participants
@fballiano @kiatng @ADDISON74 @elidrissidev