Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation errors are not suppressed anymore #3102

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Deprecation errors are not suppressed anymore #3102

merged 1 commit into from
Mar 20, 2023

Conversation

fballiano
Copy link
Contributor

Since we're moving forward with PHP versions and people will need to upgrade their stack sooner or later I think it's time to avoid suppressing deprecation errors.

Without the special treatment that you see in app/code/core/Mage/Core/functions.php all deprecation errors will be logged, and if DEVELOPER_MODE is enabled then they will trigger an error.

Why I did this? Cause it's better that people start to see this logs and fix their deprecation errors because they will become errors with new versions of PHP.

Also this PR removes the need for the specific DEV_PHP_STRICT that way introduced lately.

Manual testing scenarios (*)

  1. test with php 8.1
  2. edit a header.phtml and add a trim(); (which triggers a deprecation error)
  3. refresh, now there's an error logged in system.log
  4. enable developer mode
  5. refresh, now the deprecation error is a full error shown on page

@github-actions github-actions bot added Component: Core Relates to Mage_Core documentation labels Mar 19, 2023
@fballiano fballiano merged commit db68c32 into OpenMage:1.9.4.x Mar 20, 2023
@fballiano fballiano deleted the phpstrict branch March 20, 2023 08:23
@fballiano
Copy link
Contributor Author

merged and 20ed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants