Deprecation errors are not suppressed anymore #3102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're moving forward with PHP versions and people will need to upgrade their stack sooner or later I think it's time to avoid suppressing deprecation errors.
Without the special treatment that you see in app/code/core/Mage/Core/functions.php all deprecation errors will be logged, and if DEVELOPER_MODE is enabled then they will trigger an error.
Why I did this? Cause it's better that people start to see this logs and fix their deprecation errors because they will become errors with new versions of PHP.
Also this PR removes the need for the specific DEV_PHP_STRICT that way introduced lately.
Manual testing scenarios (*)
trim();
(which triggers a deprecation error)