Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Deprecation errors are not suppressed anymore (#3102)" #3176

Closed
wants to merge 683 commits into from
Closed

Revert "Deprecation errors are not suppressed anymore (#3102)" #3176

wants to merge 683 commits into from

Conversation

sreichel
Copy link
Contributor

Description (*)

This reverts commit 400c85a.

DEVELOPER_MODE is turned on to see exceptions, but i really dont want to see "Deprecated functionality:" errors for common actions.

Related Pull Requests

  1. See Deprecation errors are not suppressed anymore #3102

Manual testing scenarios (*)

  1. php 8.1
  2. admin -> customer ->select a customer
Deprecated functionality: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated  in /var/www/html/app/design/adminhtml/default/default/template/widget/tabs.phtml on line 29

#0 [internal function]: mageCoreErrorHandler(8192, 'preg_match(): P...', '/var/www/html/a...', 29)
#1 /var/www/html/app/design/adminhtml/default/default/template/widget/tabs.phtml(29): preg_match('/\\s?ajax\\s?/', NULL)
#2 /var/www/html/app/code/core/Mage/Core/Block/Template.php(251): include('/var/www/html/a...')
#3 /var/www/html/app/code/core/Mage/Core/Block/Template.php(288): Mage_Core_Block_Template->fetchView('adminhtml/defau...')

Questions or comments

Should be removed in next when php81+ is battle tested?

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

sreichel and others added 30 commits December 22, 2022 22:07
@sreichel @fballiano
Fixed bugs for adminhtml save base urls (#2800)
7b95491
@sreichel @fballiano
Added getApplyTo() to Mage_Eav_Model_Entity_Attribute_Abstract. ref #…
12cfca7 
…2829 (#2836)
@sreichel @fballiano
PHPStan: step back to level 4 (#2837)
2671459
@sreichel @fballiano
Removed Mage_PageCache (#2813)
af6d75c
@fballiano
Fix methods signature, ref #1610 (#2838)
4a2475c
@fballiano
Merge branch '20.0' into merge_v19_v20
5cf8e57
@sreichel
Updated phpstan.dist.baseline.neon
9be0e96
@sreichel @fballiano
PHPStan: step back to level 4 (#2837)
50928bf
@fballiano
Version bump (#2835)
14b760e
@sreichel @fballiano
Change OpenMage version compare (#2839)
7c5b68e
@sreichel @fballiano
PHPStan: working on level 3 (#2840)
23e49e6
@sreichel @fballiano
Added dependabot.yml (#2841)
6c17c78
@fballiano
Moved note about PHP7.2 since it is not supported anymore (#2842)
ca5eed5
@dependabot @fballiano
Bump tj-actions/changed-files from 34 to 35 (#2843)
6603a56 
Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 34 to 35.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@v34...v35)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>
@dependabot @fballiano
Bump symfonycorp/security-checker-action from 4 to 5 (#2845)
3da6629 
Bumps [symfonycorp/security-checker-action](https://github.com/symfonycorp/security-checker-action) from 4 to 5.
- [Release notes](https://github.com/symfonycorp/security-checker-action/releases)
- [Commits](symfonycorp/security-checker-action@v4...v5)

---
updated-dependencies:
- dependency-name: symfonycorp/security-checker-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @fballiano
Bump EnricoMi/publish-unit-test-result-action from 1.6 to 1.40 (#2846)
79aa866 
Bumps [EnricoMi/publish-unit-test-result-action](https://github.com/EnricoMi/publish-unit-test-result-action) from 1.6 to 1.40.
- [Release notes](https://github.com/EnricoMi/publish-unit-test-result-action/releases)
- [Commits](EnricoMi/publish-unit-test-result-action@v1.6...v1.40)

---
updated-dependencies:
- dependency-name: EnricoMi/publish-unit-test-result-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @fballiano
Bump pelago/emogrifier from 6.0.0 to 7.0.0 (#2844)
29b61b0 
Bumps [pelago/emogrifier](https://github.com/MyIntervals/emogrifier) from 6.0.0 to 7.0.0.
- [Release notes](https://github.com/MyIntervals/emogrifier/releases)
- [Changelog](https://github.com/MyIntervals/emogrifier/blob/main/CHANGELOG.md)
- [Commits](MyIntervals/emogrifier@v6.0.0...v7.0.0)

---
updated-dependencies:
- dependency-name: pelago/emogrifier
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@sreichel @fballiano
Added helper for admin button onclick actions (#2784)
f817659
@sreichel @fballiano
Added shell/ to checks (#2848)
ca2ee60 
* Added shell to checks

* Minor update

- short array
- phpdocs

* Minor update

- short array
- phpdocs

* Updated phpstan.dist.baseline.neon

* Updated labeler.yml
@Flyingmana @fballiano
Autoload without hiding errors (#2300)
f177532
@sreichel
Updated phpstan.dist.baseline.neon
60eb999
@elidrissidev @fballiano
Use correct country code for Greece VAT validation (#2849)
373091b
@sreichel @fballiano
Updated lib/Varien for PHP8.1 (#2802)
e90fa82
@fballiano
Added .dist and .neon to "deny from all" in .htaccess (#2852)
bdfd416
@fballiano @sreichel
Added notes about composer library/modules to README (for 19.5.x and …
b85eea0 
…20.1.x) (#2851)

* Added notes about 19.5 and 20.1 in README

* Removed note for mcrypt

It was removed from PHP7.2

* Moved versioning section

* Updated requirements

* Updated badges

* No need for the "unofficial" word

* Added note about gpatch

* Typo

Co-authored-by: Sven Reichel <github-sr@hotmail.com>
@sreichel @fballiano
Remove mixed type usage to support PHP7 (#2856)
ef7e408
@justinbeaty @fballiano
Added translation helper shell script (#2332)
e9ae9c8
@sreichel @fballiano
PHPMD: added basic config (#2771)
cce33d0
@sreichel @fballiano
Load dev shell scripts as composer module (#2853)
dc446c0
@fballiano
Fixed tag aggregation indexer query (#2858)
e5bf8cb
@github-actions github-actions bot added Component: Bundle Relates to Mage_Bundle Component: Captcha Relates to Mage_Captcha Component: Catalog Relates to Mage_Catalog Component: CatalogInventory Relates to Mage_CatalogInventory Component: CatalogRule Relates to Mage_CatalogRule Component: CatalogIndex Relates to Mage_CatalogIndex Component: CatalogSearch Relates to Mage_CatalogSearch Component: Centinel Relates to Mage_Centinel Component: Checkout Relates to Mage_Checkout Component: Cm/RedisSession Relates to Cm_RedisSession Component: Cms Relates to Mage_Cms Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches Component: Contacts Relates to Mage_Contacts Component: Cron Relates to Mage_Cron Component: CurrencySymbol Relates to Mage_CurrencySymbol Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Directory Relates to Mage_Directory ddev environment htaccess Mage.php Relates to app/Mage.php php-cs-fixer phpcs phpstan PHPStorm phpunit labels Apr 20, 2023
@sreichel sreichel mentioned this pull request May 4, 2023
Closed
4 tasks
@sreichel sreichel deleted the revert-3102 branch May 4, 2023 00:24
@sreichel sreichel mentioned this pull request Feb 20, 2024
Open
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Admin Relates to Mage_Admin Component: Adminhtml Relates to Mage_Adminhtml Component: AdminNotification Relates to Mage_AdminNotification Component: Api PageRelates to Mage_Api Component: Api2 Relates to Mage_Api2 Component: Authorizenet Relates to Mage_Authorizenet Component: Backup Relates to Mage_Backup Component: Bundle Relates to Mage_Bundle Component: Captcha Relates to Mage_Captcha Component: Catalog Relates to Mage_Catalog Component: CatalogIndex Relates to Mage_CatalogIndex Component: CatalogInventory Relates to Mage_CatalogInventory Component: CatalogRule Relates to Mage_CatalogRule Component: CatalogSearch Relates to Mage_CatalogSearch Component: Centinel Relates to Mage_Centinel Component: Checkout Relates to Mage_Checkout Component: Cm/RedisSession Relates to Cm_RedisSession Component: Cms Relates to Mage_Cms Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches Component: Contacts Relates to Mage_Contacts Component: Core Relates to Mage_Core Component: Cron Relates to Mage_Cron Component: CurrencySymbol Relates to Mage_CurrencySymbol Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Directory Relates to Mage_Directory ddev documentation Don't forget this PR environment htaccess Mage.php Relates to app/Mage.php php-cs-fixer phpcs phpstan PHPStorm phpunit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.