Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduced getWebsiteId() calls #3154

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Reduced getWebsiteId() calls #3154

merged 1 commit into from
Apr 10, 2023

Conversation

luigifab
Copy link
Contributor

@luigifab luigifab commented Apr 9, 2023 •
edited
Loading

Description

This reduce number of getWebsiteId() calls (found with Blackfire).
Same as #3007 #2957 #2677 #2699 #1571.

before:
website-before

after:
website-after

Yes this will not change many things, but this + many others...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the Component: Core Relates to Mage_Core label Apr 9, 2023
@fballiano fballiano merged commit d3dd0f0 into OpenMage:main Apr 10, 2023
@fballiano fballiano changed the title Reduce getWebsiteId calls Reduced getWebsiteId() calls Apr 10, 2023
@luigifab luigifab deleted the getwebsiteid branch April 10, 2023 08:25
@luigifab luigifab mentioned this pull request Apr 11, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addison74 addison74 addison74 approved these changes

@kiatng kiatng kiatng approved these changes

Assignees
No one assigned
Labels
Component: Core Relates to Mage_Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luigifab @kiatng @addison74 @fballiano