Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduced calls to char() method #3161

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Reduced calls to char() method #3161

merged 1 commit into from
Apr 11, 2023

Conversation

luigifab
Copy link
Contributor

@luigifab luigifab commented Apr 11, 2023 •
edited
Loading

Description

This reduce number of char() calls (found with Blackfire).
Same as #3154 #3007 #2957 #2677 #2699 #1571.

before:
char-before

after:
char-after

Yes this will not change many things, but this + many others...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* labels Apr 11, 2023
@fballiano fballiano merged commit 38d0911 into OpenMage:main Apr 11, 2023
@fballiano fballiano changed the title Reduced char calls Reduced calls to char() method Apr 11, 2023
@luigifab luigifab deleted the char branch April 11, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addison74 addison74 addison74 approved these changes

@fballiano fballiano fballiano approved these changes

Assignees
No one assigned
Labels
Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/*
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luigifab @fballiano @addison74