Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFJS doc parser: some commands are missing scope #113

Open
vvmnnnkv opened this issue Jul 7, 2020 · 0 comments
Open

TFJS doc parser: some commands are missing scope #113

vvmnnnkv opened this issue Jul 7, 2020 · 0 comments
Labels
crawler With regards to our documentation crawler Type: Bug 🐛 Some functionality not working in the codebase as intended

Comments

@vvmnnnkv
Copy link
Member

vvmnnnkv commented Jul 7, 2020

Description

Noticed issue in tfjs parsed .json file:
e.g. if you see tf.GraphModel in tfjs API, it's methods are listed w/o tf.GraphModel. prefix.
Doc parser doesn't add tf.GraphModel prefix, so all these methods appear as is they were in global scope.

How to Reproduce

See tf.Tensor, tf.GraphModel, etc. in API doc https://js.tensorflow.org/api/latest/#class:GraphModel
Check docs-crawler/docs/output/tfjs/1.5.1.json, notice all methods are in global scope.

Expected Behavior

Parsed data should contain indication of class where method belongs.
(Or just skip all these methods because they are not under tf. but rather in specific classes, which requires target support anyway?)

Screenshots

n/a

System Information

  • OS: [e.g. iOS]
  • OS Version: [e.g. 22]
  • Language Version: [e.g. Python 3.7, Node 10.18.1]
  • Package Manager Version: [e.g. Conda 4.6.1, NPM 6.14.1]
  • Browser (if applicable): [e.g. Google Chrome]
  • Browser Version (if applicable): [e.g. 81.0.4044.138]

Additional Context

Might be related to #16

@vvmnnnkv vvmnnnkv added Type: Bug 🐛 Some functionality not working in the codebase as intended crawler With regards to our documentation crawler labels Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crawler With regards to our documentation crawler Type: Bug 🐛 Some functionality not working in the codebase as intended
Projects
None yet
Development

No branches or pull requests

1 participant